Closed Bug 1474352 Opened 6 years ago Closed 6 years ago

Active tab is missing styling in tab overflow menu

Categories

(Firefox :: Theme, defect, P2)

63 Branch
defect

Tracking

()

RESOLVED DUPLICATE of bug 1470947
Tracking Status
firefox62 --- fixed
firefox63 --- fixed

People

(Reporter: ewright, Unassigned)

References

Details

(Keywords: regression)

Attachments

(1 file)

Attached image missing_box-shadow.png (deleted) —
The visible tabs in the overflow menu are highlighted on the right side with a light grey box-shadow. The active tab has no highlight on the right whether it is visible or not. Upon inspecting, there is an error in the styling "--blue-40 is not set". I believe `box-shadow: inset 4px 0 var(--blue-40);` should be `-4px` instead to have the highlight remain on the right.
On mac OS Nighly 63.0a1
Is it a recent regression?
Version: 62 Branch → 63 Branch
v61 same highlight to the right as all other visible tabs, check mark to the left v62 highlight is missing in the same way as described originally, no check mark
Dão, do you know if this was an intentional change?
Component: Menus → Tabbed Browser
Flags: needinfo?(dao+bmo)
Bug 1470947 removes the visible tab styling but this still needs fixing: (In reply to Erica Wright [:ewright] from comment #0) > Upon inspecting, there is an error in the styling "--blue-40 is not set". > I believe `box-shadow: inset 4px 0 var(--blue-40);` should be `-4px` instead > to have the highlight remain on the right.
Blocks: 1446101
Component: Tabbed Browser → Theme
Depends on: 1470947
Flags: needinfo?(dao+bmo) → needinfo?(mstriemer)
Priority: -- → P2
Summary: Active tab in missing styling in overflow menu → Active tab is missing styling in tab overflow menu
(In reply to Dão Gottwald [::dao] from comment #5) > Bug 1470947 removes the visible tab styling but this still needs fixing: > > (In reply to Erica Wright [:ewright] from comment #0) > > Upon inspecting, there is an error in the styling "--blue-40 is not set". > > I believe `box-shadow: inset 4px 0 var(--blue-40);` should be `-4px` instead > > to have the highlight remain on the right. Actually, the "part 4" patch in bug 1470947 fixes the variable too, but I get the offset is still wrong. (Too bad the four parts couldn't land yet because the fifth one wasn't ready. That's why it's better to have one bug per issue.)
This is fixed by bug 1470947, as Dão mentioned.
Status: NEW → RESOLVED
Closed: 6 years ago
Flags: needinfo?(mstriemer)
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: