Closed Bug 1474364 Opened 6 years ago Closed 6 years ago

Flex badge in inspector doesn't toggle off, on second click

Categories

(DevTools :: Inspector, defect, P3)

defect

Tracking

(firefox63 fixed)

RESOLVED FIXED
Firefox 63
Tracking Status
firefox63 --- fixed

People

(Reporter: dholbert, Assigned: gl)

References

Details

Attachments

(3 files)

Attached file testcase 1 (deleted) —
STR: 0. enable about:config prefs: devtools.inspector.flexboxHighlighter.enabled devtools.flexboxinspector.enabled 1. Visit attached testcase and open DevTools inspector. 2. Try clicking the "flex" and "grid" badges in the inspector -- clicking each badge several times in a row. ACTUAL RESULTS: The grid badge seems to toggle on & off correctly when you click it multiple times, but the flex badge does not -- it just stays selected/highlighted after it's been clicked, even on repeat clicks. EXPECTED RESULTS: Flex badge should toggle off (highlighting/outline should disappear) on the second click.
Attached video screencast of bug (deleted) —
Assignee: nobody → gl
Status: NEW → ASSIGNED
Priority: -- → P3
Comment on attachment 8992003 [details] Bug 1474364 - Clear the stored flexbox highlighter shown before emitting the event. https://reviewboard.mozilla.org/r/256894/#review263970
Attachment #8992003 - Flags: review?(pbrosset) → review+
Pushed by gabriel.luong@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/40d4a3f314f8 Clear the stored flexbox highlighter shown before emitting the event. r=pbro
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 63
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: