I didn't realize when I wrote the bug 1368808 patch that "Light" and "Automatic" were different on Windows; I think that's the cause of the main issue here. I did not intend to make the Default setting behave differently than it did before when the Windows dark mode is not active. It wasn't an intentional decision, just an oversight. Since this is my mess, I'll look into cleaning it up.

... aaaaand I *still* didn't understand the problem correctly. The Default setting *doesn't* behave differently when dark mode isn't on. The problem is that the Automatic option effectively disappears when dark mode is on, because it isn't the same thing as Light. That puts me a bit out of my depth; I'm not even sure how to trigger the Automatic state, much less what to do about the necessary new UI.

Just giving my 2-c... So, how can I select the current "Default (light-on-dark)" theme after FF62 forcing us between light or dark only? Let's suppose: I use macOS Mojave dark theme and want to use the light-on-dark theme as before because its fancy and I'm fine with it, how can I do it? As a regular user, I agree with comment 25: - Automatic (or "defined by OS" or whatever) - Light (force light theme, ignore OS) - Dark (force dark theme, ignore OS) - Light-on-Dark (or whatever, to force the current Default theme, ignore OS) 63 is on Beta, but 64 just went Nightly.

Hi everyone, I'd like to just chime in and propose an idea for OS X... I understand it's a conscious choice to select the dark mode appearance, and we should expect apps to be dark as a result, and that there is some discussion regarding what the idea of "Default" should be for the theme based on system settings, but it does seem strange that when the system appearance is in light mode, all three themes, even "Dark," work perfectly. But once in dark mode, selecting the "Default" theme looks exactly like the "Dark" theme, which is clearly an available option for me to choose if I want. I just prefer the "Default" theme even though my system appearance is in "Dark" mode because it looks prettier and feels kind of like a hybrid between the two. The "Light" theme isn't forced on people who use the "Light" system appearance. So I think I would like to propose that the current "Default" theme (with the slight transparent tab bar) just be called "Firefox" and leave the other two themes as "Light" and "Dark." If the developers want to default, or, automatically select, the theme to be "Dark" when the system appearance changes to "Dark," then that's great, but I would just like to use the current "Default" theme as well even while dark mode is enabled on my system. If I can use the "Light" theme when my mac's appearance is in "Dark" mode, why not allow me to use the current "Default" theme? It looks different from the other two. It's prettier and has transparency that makes it meld into the Finder bar at the top of my screen super nicely and looks clean. I think just calling it "Standard" or "Firefox" may help alleviate some of the confusion about what should be defining "Default." But honestly to summarize, I just want the option to use the current "Default" theme while my system is set to dark mode because it's way prettier. That's literal all. 3 options for both system appearances. Any way to make that happen is what I want. Thank you for hearing me out, and sorry for repeating myself. I just don't think taking the choice away from users is a good thing. Cheers.

(In reply to Dão Gottwald [::dao] from comment #41) > Yep, these are starting to sound like more realistic options. I'm not > convinced it's worth the effort and added UI complexity, and I'm leaning > towards wontfixing this or morphing it to address comment 16. To be honest, I definitely believe that Tim Nguyen's suggestion in comment 40 is exactly what would clear everything up. Having the 4 options seems to satisfy everyone's concerns and removes the current confusion of the default theme not applying what is being previewed once it is selected. It also opens the choice to use the "Hardcoded Photon defaults" even while system is in dark mode, which is clearly desired. It just looks better. I find Tim Nguyen's suggested options incredibly self-explanatory as well and believe it will simplify things for users as it removes the guessing of what is happening when themes do not appear to be functioning properly. I'm literally only here because my choice of browser theme was taken away from me and thought it was a bug. But this is also the problem with comment 16: that it removes the theme that we want to use with dark system appearance enabled. That will essentially lock users with dark system appearances to the dark or light theme in Firefox, but not the original. Users like the default theme. We want to use it. The browser won't let us because it is locking onto our system appearance and there is no other way to select it. Therefore, Tim Nguyen's suggestion is absolutely the best option.

(In reply to Dão Gottwald [::dao] from comment #28) > (In reply to Brunno Pleffken from comment #27) > > Let's suppose: I use macOS Mojave dark theme and want to use the > > light-on-dark theme as before because its fancy and I'm fine with it, how > > can I do it? > > First of all I would suggest you shouldn't use the macOS Mojave dark theme > if you don't want apps to be dark. > > My second suggestion would be to install a custom Firefox theme that > mimmicks the look your after. I'm attempting to create one now as a workaround for those of us on Macs that prefer the default look of Firefox but a dark taskbar. Could anyone suggest a way to track all of the changes introduced by LWT? I can see that the particular variables of the dark theme are defined here, but it's a bit difficult to follow how they get applied... and it appears that merely negating them leaves me with a totally unstyled browser rather than the default theme. https://github.com/mozilla/gecko-dev/blob/master/browser/components/nsBrowserGlue.js#L1037 There appear to be a variety of places where the default styling is applied by selectors containing `:not(:-moz-lwtheme)`, which presents an intriguing paradox for someone attempting to create a theme that applies those same rules. (In reply to Akenera from comment #42) > I find Tim Nguyen's suggested options incredibly self-explanatory as well > and believe it will simplify things for users as it removes the guessing of > what is happening when themes do not appear to be functioning properly. I'm > literally only here because my choice of browser theme was taken away from > me and thought it was a bug. I couldn't agree more.

Great. You just changed browser colors without user consent. This feels very Microsofty. Not having to deal with forced user setting changes is exactly why Firefox got popular in the first place. This just feels going backwards. Please, respect the user settings on theme. The use case going wrong is: Windows set to dark app mode, browser set to default theme (previously light with windows accents, now automatic dark) Do not override the default theme with dark app mode!

(In reply to Keith Greene from comment #48) > Coming over from https://bugzilla.mozilla.org/show_bug.cgi?id=1501373 > > This is NOT limited to Windows Dark theme. I have Windows 10 Pro x64, my > Windows theme is set to "Custom" with grey backgrounds and dark blue and > light blue title bars. Most certainly NOT Dark theme, but selecting > "Default" theme in FF sets it to Dark theme. HOVERING over "Default" changes > the window to what it *should* be, but clicking it just sets it to Dark. Yes, this is exactly why we propose the idea of Tim Nguyen's comment 40 as the solution to this problem. Clearly, Dão Gottwald, this problem is not going away, and will continue to show up if it is not addressed properly. People care a lot about their choice of theme and don't want their options limited. I think all of us on this thread, and most likely many other Firefox users who are not here, would sincerely appreciate the implementation of Tim Nguyen's proposed fix to this issue. If this idea gets implemented, it literally resolves every issue proposed by this thread.

(In reply to Akenera from comment #49) > (In reply to Keith Greene from comment #48) > > Coming over from https://bugzilla.mozilla.org/show_bug.cgi?id=1501373 > > > > This is NOT limited to Windows Dark theme. I have Windows 10 Pro x64, my > > Windows theme is set to "Custom" with grey backgrounds and dark blue and > > light blue title bars. Most certainly NOT Dark theme, but selecting > > "Default" theme in FF sets it to Dark theme. HOVERING over "Default" changes > > the window to what it *should* be, but clicking it just sets it to Dark. > > Yes, this is exactly why we propose the idea of Tim Nguyen's comment 40 as > the solution to this problem. > > Clearly, Dão Gottwald, this problem is not going away, and will continue to > show up if it is not addressed properly. People care a lot about their > choice of theme and don't want their options limited. I think all of us on > this thread, and most likely many other Firefox users who are not here, > would sincerely appreciate the implementation of Tim Nguyen's proposed fix > to this issue. If this idea gets implemented, it literally resolves every > issue proposed by this thread. As long as I can go back to having my custom windows colors apply consistently to the FF window, I'll be happy. I can *almost* get there now. As I mentioned in 1501373, I can set the theme to light, which is close to my background colors, and tick the "Title Bar" checkbox at the bottom of the theme panel and that seems to behave as an override for the title bar color under Win 10, where under Win 7 it actually extends the title bar so it's above the tabs and doesn't affect color at all.

(In reply to ross from comment #52) > Going to about:config, adding a new integer field for > "ui.systemUsesDarkTheme" with the value 0 allows me to go back to the proper > "Light on Dark" theme. Done, and it successfully worked! I don't know which block of code caused this issue on v63 Nightly, but I don't see an Auto checkbox as a "high effort" or "UI complexity" code as Dão said. Perhaps an Auto button should work (in a simplified form) the following way: if auto is true [execute the current block of code, to detect system OS theme (force dark on dark)] else [does nothing - or set ui.systemUsesDarkTheme = 0 (which allows me to select any of the 3 themes)] end