Closed
Bug 1474900
Opened 6 years ago
Closed 6 years ago
Assert there are no pending image lockers instead of wallpapering.
Categories
(Core :: Graphics: ImageLib, enhancement)
Core
Graphics: ImageLib
Tracking
()
RESOLVED
FIXED
mozilla63
People
(Reporter: emilio, Assigned: emilio)
References
Details
(Keywords: sec-want, Whiteboard: [post-critsmash-triage][adv-main63-])
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
tnikkel
:
review+
|
Details | Diff | Splinter Review |
It probably means that somebody still keeps a reference to us and has forgot about unlocking us, like bug 1473637.
Assignee | ||
Comment 1•6 years ago
|
||
er, people definitely leave locks around...
Assignee | ||
Comment 2•6 years ago
|
||
So my patch most definitely wouldn't pass try given it doesn't shut down the browser correctly locally :).
I still think we should have a way to crash safely if the image tracker leaves any stale reference around... I have a long flight where I'll try to take a look at whether it's trivial to make the lock / unlock calls match, or if there's any other way.
Updated•6 years ago
|
Group: core-security → gfx-core-security
Assignee | ||
Comment 3•6 years ago
|
||
Attachment #8991512 -
Flags: review?(tnikkel)
Updated•6 years ago
|
Attachment #8991512 -
Flags: review?(tnikkel) → review+
Assignee | ||
Comment 4•6 years ago
|
||
Daniel, do you know whether this can land without sec-approval or not?
This is mostly preventive action, but this will make some of the unexplained crashes with the signature of bug 1474900 safe.
Flags: needinfo?(dveditz)
Updated•6 years ago
|
status-firefox61:
--- → wontfix
status-firefox62:
--- → affected
status-firefox63:
--- → affected
status-firefox-esr52:
--- → wontfix
status-firefox-esr60:
--- → affected
Assignee | ||
Comment 6•6 years ago
|
||
First patch missed some unit tests, and the XUL tree image cache.
Attachment #8991512 -
Attachment is obsolete: true
Attachment #8997880 -
Flags: review?(tnikkel)
Updated•6 years ago
|
Attachment #8997880 -
Flags: review?(tnikkel) → review+
Assignee | ||
Comment 7•6 years ago
|
||
Comment 8•6 years ago
|
||
Group: gfx-core-security → core-security-release
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
Comment 9•6 years ago
|
||
Emilio, is this something that should ride the trains?
Flags: needinfo?(emilio)
Assignee | ||
Comment 10•6 years ago
|
||
Yeah, I don't think we _need_ to uplift this, given the volume from the unknown crashes with the same signature as bug 1473637.
Though I don't think it'd be terribly risky to do so...
Flags: needinfo?(emilio)
Comment 11•6 years ago
|
||
Agreed, let's leave well enough alone here.
Updated•6 years ago
|
Flags: qe-verify-
Whiteboard: [post-critsmash-triage]
Updated•6 years ago
|
Whiteboard: [post-critsmash-triage] → [post-critsmash-triage][adv-main63-]
Updated•5 years ago
|
Group: core-security-release
You need to log in
before you can comment on or make changes to this bug.
Description
•