Closed
Bug 1475071
Opened 6 years ago
Closed 6 years ago
Bump tup toolchain build to version to pick up various fixes
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(firefox63 fixed)
RESOLVED
FIXED
mozilla63
| Tracking | Status | |
|---|---|---|
| firefox63 | --- | fixed |
People
(Reporter: chmanchester, Assigned: mshal)
References
Details
Attachments
(2 files)
We want to bump the rev built by the tup toolchain build to include a couple of recent fixes, at least the fix for clang builds (https://github.com/gittup/tup/commit/c3e420eaa6f2fa2b3a9f774c0e886068b2b1876a) and the fix to do less work when handling sigint (https://github.com/gittup/tup/commit/93c900387c1b9661c00a30b096f39d5916b77877).
|
Assignee | |
Comment 1•6 years ago
|
||
I also wanted to pick up the debug logging support, which should land Real Soon Now (TM).
|
|
Assignee | |
Updated•6 years ago
|
Assignee: nobody → mshal
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
|
Reporter | |
Updated•6 years ago
|
Attachment #8996348 -
Flags: review?(core-build-config-reviews) → review?(cmanchester)
Attachment #8996349 -
Flags: review?(core-build-config-reviews) → review?(cmanchester)
|
|
Reporter | |
Comment 4•6 years ago
|
||
| mozreview-review | ||
Comment on attachment 8996348 [details]
Bug 1475071 - Bump tup version to v0.7.7;
https://reviewboard.mozilla.org/r/260482/#review267606
Attachment #8996348 -
Flags: review?(cmanchester) → review+
|
|
Reporter | |
Comment 5•6 years ago
|
||
| mozreview-review | ||
Comment on attachment 8996349 [details]
Bug 1475071 - Enable --no-sync and --debug-logging when running tup;
https://reviewboard.mozilla.org/r/260484/#review267608
::: commit-message-040a4:9
(Diff revision 1)
> +The --debug-logging flag saves logs under .tup/log to show what files
> +changes or were deleted, as well as the corresponding build DAG. This
> +can be helpful when trying to investigate why something was rebuilt.
At some point it might be helpful to go over informally or in documentation what the logs look like so myself or someone else running the build might be able to use them to debug their build.
Attachment #8996349 -
Flags: review?(cmanchester) → review+
Pushed by mshal@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d300ddf85448
Bump tup version to v0.7.7; r=chmanchester
https://hg.mozilla.org/integration/autoland/rev/e1e6b6c80b11
Enable --no-sync and --debug-logging when running tup; r=chmanchester
|
|
Assignee | |
Comment 7•6 years ago
|
||
(In reply to Chris Manchester (:chmanchester) from comment #5)
> At some point it might be helpful to go over informally or in documentation
> what the logs look like so myself or someone else running the build might be
> able to use them to debug their build.
That's a good idea, though without much real-world experience using them at this point I'd find it difficult to write a guide on best practices. I mostly wanted to make sure it's enabled now so that if someone sees something compile unexpectedly (or not compile unexpectedly), they could send the logs so I could trace back through to reproduce the issue.
|
||
Comment 8•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/d300ddf85448
https://hg.mozilla.org/mozilla-central/rev/e1e6b6c80b11
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox63:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in
before you can comment on or make changes to this bug.
Description
•