Closed Bug 1475390 Opened 6 years ago Closed 6 years ago

Fail configure if the Tup backend is specified on a platform other than Linux

Categories

(Firefox Build System :: General, enhancement)

enhancement
Not set
normal

Tracking

(firefox63 fixed)

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: chmanchester, Assigned: chmanchester)

References

Details

Attachments

(1 file)

We don't want people to waste time trying to get tup set up on Windows or Linux yet.
(In reply to Chris Manchester (:chmanchester) from comment #0) > We don't want people to waste time trying to get tup set up on Windows or > Linux yet. Of course I mean Windows or macOS.
Assignee: nobody → cmanchester
Attachment #8992103 - Flags: review?(core-build-config-reviews) → review?(gps)
Comment on attachment 8992103 [details] Bug 1475390 - Fail configure if Tup is specified on a non-linux build. https://reviewboard.mozilla.org/r/256988/#review263836
Attachment #8992103 - Flags: review?(gps) → review+
Pushed by gszorc@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b3eb58b5214a Fail configure if Tup is specified on a non-linux build. r=gps
Comment on attachment 8992103 [details] Bug 1475390 - Fail configure if Tup is specified on a non-linux build. https://reviewboard.mozilla.org/r/256988/#review263842 Code analysis found 1 defect in this patch: - 1 defect found by mozlint You can run this analysis locally with: - `./mach lint path/to/file` (JS/Python) If you see a problem in this automated review, please report it here: http://bit.ly/2y9N9Vx ::: build/moz.configure/tup.configure:58 (Diff revision 1) > min_rustc_version = Version('1.28.0') > if tup and rustc_info.version < min_rustc_version: > die('Cannot build with tup and rustc %s. please update to at least ' > 'rustc %s to continue.', rustc_info.version, min_rustc_version) > > +@depends(tup, target, build_project) Error: Expected 2 blank lines, found 1 [flake8: E302]
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: