Check for double-free, use-after-free and offset problems involving C++ delete. There are currently no clang-analyzer-cplusplus.NewDelete warnings in mozilla-central! https://clang-analyzer.llvm.org/available_checks.html Review commit: https://reviewboard.mozilla.org/r/257076/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/257076/

Check for memory leaks. Traces memory managed by new/ delete. There are currently no clang-analyzer-cplusplus.NewDeleteLeaks warnings in mozilla-central! https://clang-analyzer.llvm.org/available_checks.html Review commit: https://reviewboard.mozilla.org/r/257078/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/257078/

Check the size argument passed to strncat for common erroneous patterns. There are currently no clang-analyzer-unix.cstring.BadSizeArg warnings in mozilla-central! https://clang-analyzer.llvm.org/available_checks.html Review commit: https://reviewboard.mozilla.org/r/257080/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/257080/

Check for null pointers being passed as arguments to C string functions. There are no clang-analyzer-unix.cstring.NullArg warnings in mozilla-central! strlen strnlen strcpy strncpy strcat strncat strcmp strncmp strcasecmp strncasecmp https://clang-analyzer.llvm.org/available_checks.html Review commit: https://reviewboard.mozilla.org/r/257082/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/257082/

Check for memory leaks, double free, and use-after-free and offset problems involving malloc. There are currently no clang-analyzer-unix.Malloc warnings in mozilla-central! https://clang-analyzer.llvm.org/available_checks.html Review commit: https://reviewboard.mozilla.org/r/257084/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/257084/

This check finds memset() calls with potential mistakes in their arguments. There are currently no bugprone-suspicious-memset-usage warnings in mozilla-central! https://clang.llvm.org/extra/clang-tidy/checks/bugprone-suspicious-memset-usage.html Review commit: https://reviewboard.mozilla.org/r/257086/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/257086/

This check finds side effects from repeated macro arguments: https://clang.llvm.org/extra/clang-tidy/checks/bugprone-macro-repeated-side-effects.html There are currently 16 misc-macro-repeated-side-effects warnings in mozilla-central, but they are all in third-party gfx/cairo code: gfx/cairo/cairo/src/cairo-tor-scan-converter.c:1432:10: warning: side effects in the 1st macro argument 'x' are repeated in macro expansion gfx/cairo/libpixman/src/pixman-access.c:1011:16: warning: side effects in the 2nd macro argument 'ptr' are repeated in macro expansion gfx/cairo/libpixman/src/pixman-access.c:1037:16: warning: side effects in the 2nd macro argument 'ptr' are repeated in macro expansion gfx/cairo/libpixman/src/pixman-access.c:1062:16: warning: side effects in the 2nd macro argument 'ptr' are repeated in macro expansion gfx/cairo/libpixman/src/pixman-access.c:1088:16: warning: side effects in the 2nd macro argument 'ptr' are repeated in macro expansion gfx/cairo/libpixman/src/pixman-access.c:1107:16: warning: side effects in the 2nd macro argument 'ptr' are repeated in macro expansion gfx/cairo/libpixman/src/pixman-access.c:1126:27: warning: side effects in the 2nd macro argument 'ptr' are repeated in macro expansion gfx/cairo/libpixman/src/pixman-access.c:1194:21: warning: side effects in the 2nd macro argument 'ptr' are repeated in macro expansion gfx/cairo/libpixman/src/pixman-access.c:1258:16: warning: side effects in the 2nd macro argument 'ptr' are repeated in macro expansion gfx/cairo/libpixman/src/pixman-access.c:600:28: warning: side effects in the 2nd macro argument 'ptr' are repeated in macro expansion gfx/cairo/libpixman/src/pixman-access.c:629:28: warning: side effects in the 2nd macro argument 'ptr' are repeated in macro expansion gfx/cairo/libpixman/src/pixman-access.c:660:28: warning: side effects in the 2nd macro argument 'ptr' are repeated in macro expansion gfx/cairo/libpixman/src/pixman-access.c:690:28: warning: side effects in the 2nd macro argument 'ptr' are repeated in macro expansion gfx/cairo/libpixman/src/pixman-access.c:721:28: warning: side effects in the 2nd macro argument 'ptr' are repeated in macro expansion gfx/cairo/libpixman/src/pixman-access.c:986:16: warning: side effects in the 2nd macro argument 'ptr' are repeated in macro expansion gfx/cairo/libpixman/src/pixman-edge-imp.h:126:20: warning: side effects in the 2nd macro argument 'ptr' are repeated in macro expansion Review commit: https://reviewboard.mozilla.org/r/257088/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/257088/

Finds string constructors that are suspicious and probably errors. There are currently no misc-string-constructor warnings in mozilla-central! https://clang.llvm.org/extra/clang-tidy/checks/bugprone-string-constructor.html Review commit: https://reviewboard.mozilla.org/r/257090/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/257090/

The check finds assignments of an integer to std::string: https://clang.llvm.org/extra/clang-tidy/checks/bugprone-string-integer-assignment.html There are currently ten misc-string-integer-assignment warnings in mozilla-central, but they are all in third-party Breakpad code: toolkit/crashreporter/google-breakpad/src/processor/minidump.cc:306:17: warning: an integer is interpreted as a character code when assigning it to a string; if this is intended, cast the integer to the appropriate character type; if you want a string representation, use the appropriate conversion facility toolkit/crashreporter/google-breakpad/src/processor/minidump.cc:307:17: warning: an integer is interpreted as a character code when assigning it to a string; if this is intended, cast the integer to the appropriate character type; if you want a string representation, use the appropriate conversion facility toolkit/crashreporter/google-breakpad/src/processor/minidump.cc:309:17: warning: an integer is interpreted as a character code when assigning it to a string; if this is intended, cast the integer to the appropriate character type; if you want a string representation, use the appropriate conversion facility toolkit/crashreporter/google-breakpad/src/processor/minidump.cc:310:17: warning: an integer is interpreted as a character code when assigning it to a string; if this is intended, cast the integer to the appropriate character type; if you want a string representation, use the appropriate conversion facility toolkit/crashreporter/google-breakpad/src/processor/minidump.cc:311:17: warning: an integer is interpreted as a character code when assigning it to a string; if this is intended, cast the integer to the appropriate character type; if you want a string representation, use the appropriate conversion facility toolkit/crashreporter/google-breakpad/src/processor/minidump.cc:313:17: warning: an integer is interpreted as a character code when assigning it to a string; if this is intended, cast the integer to the appropriate character type; if you want a string representation, use the appropriate conversion facility toolkit/crashreporter/google-breakpad/src/processor/minidump.cc:314:17: warning: an integer is interpreted as a character code when assigning it to a string; if this is intended, cast the integer to the appropriate character type; if you want a string representation, use the appropriate conversion facility toolkit/crashreporter/google-breakpad/src/processor/minidump.cc:315:17: warning: an integer is interpreted as a character code when assigning it to a string; if this is intended, cast the integer to the appropriate character type; if you want a string representation, use the appropriate conversion facility toolkit/crashreporter/google-breakpad/src/processor/minidump.cc:316:17: warning: an integer is interpreted as a character code when assigning it to a string; if this is intended, cast the integer to the appropriate character type; if you want a string representation, use the appropriate conversion facility Review commit: https://reviewboard.mozilla.org/r/257092/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/257092/

This check finds potentially swapped function arguments by looking at implicit conversions. There are currently no misc-swapped-arguments warnings in mozilla-central! https://clang.llvm.org/extra/clang-tidy/checks/bugprone-swapped-arguments.html Review commit: https://reviewboard.mozilla.org/r/257094/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/257094/

This check finds unused namespace alias declarations. There are currently no misc-unused-alias-decls warnings in mozilla-central! https://clang.llvm.org/extra/clang-tidy/checks/misc-unused-alias-decls.html Review commit: https://reviewboard.mozilla.org/r/257096/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/257096/

Comment on attachment 8992248 [details] Bug 1475882 - clang-analyzer: Enable clang-analyzer-unix.cstring.BadSizeArg check. Review request updated; see interdiff: https://reviewboard.mozilla.org/r/257080/diff/1-2/

Comment on attachment 8992249 [details] Bug 1475882 - clang-analyzer: Enable clang-analyzer-unix.cstring.NullArg check. Review request updated; see interdiff: https://reviewboard.mozilla.org/r/257082/diff/1-2/

Comment on attachment 8992250 [details] Bug 1475882 - clang-analyzer: Enable clang-analyzer-unix.Malloc check. Review request updated; see interdiff: https://reviewboard.mozilla.org/r/257084/diff/1-2/

Comment on attachment 8992251 [details] Bug 1475882 - clang-tidy: Enable bugprone-suspicious-memset-usage check. Review request updated; see interdiff: https://reviewboard.mozilla.org/r/257086/diff/1-2/

Comment on attachment 8992252 [details] Bug 1475882 - Enable clang-tidy's misc-macro-repeated-side-effects check. Review request updated; see interdiff: https://reviewboard.mozilla.org/r/257088/diff/1-2/

Comment on attachment 8992253 [details] Bug 1475882 - clang-tidy: Enable misc-string-constructor check. Review request updated; see interdiff: https://reviewboard.mozilla.org/r/257090/diff/1-2/

Comment on attachment 8992254 [details] Bug 1475882 - clang-tidy: Enable misc-string-integer-assignment check. Review request updated; see interdiff: https://reviewboard.mozilla.org/r/257092/diff/1-2/

Comment on attachment 8992255 [details] Bug 1475882 - Enable clang-tidy's misc-swapped-arguments check. Review request updated; see interdiff: https://reviewboard.mozilla.org/r/257094/diff/1-2/

Comment on attachment 8992256 [details] Bug 1475882 - Enable clang-tidy's misc-unused-alias-decls check. Review request updated; see interdiff: https://reviewboard.mozilla.org/r/257096/diff/1-2/