Closed
Bug 147625
Opened 22 years ago
Closed 12 years ago
strange characters in message composer title/subject (was Strange undo/redo interaction with oninput handlers)
Categories
(Core :: DOM: Editor, defect, P2)
Tracking
()
RESOLVED
FIXED
Future
People
(Reporter: neil, Assigned: graememcc)
References
Details
Attachments
(1 file)
(deleted),
text/html
|
Details |
Using Build ID: 2002052508
Steps to reproduce problem:
1. Open Editor
2. Insert/Image
3. In the image location field, type #,BKSP,#,BKSP,#,BKSP,#,BKSP,#,BKSP
4. Press ^Z ten times, then ^Y ten times, then ^Z ten times
Expected results: "OK" button is enabled when the location is #
Actual results:
"OK" button is enabled after typing each # as expected
"OK" button is not enabled after any of the ^Zs
"OK" button is not enabled after the first two ^Ys
"OK" button is enabled on the 3rd, 5th, 7th and 9th ^Ys as expected
"OK" button is enabled on the next ^Z as expected
"OK" button is not enabled on any of the rest of the ^Zs
Reporter | ||
Comment 1•22 years ago
|
||
This now (since bug 60917 was fixed) also affects message compose.
Steps to reproduce problem:
1. Open Message Compose
2. Focus the Subject field (Alt+S)
3. Type ^Z,^Z,^Y,^Y (at this point undo/redo should not be possible!)
4. Type #,^Z,^Z
5. Type #,BKSP,^Z,^Z,^Y,^Y
Some very strange things happen to the title...
Blocks: 60917
Severity: normal → major
Reporter | ||
Comment 2•22 years ago
|
||
The second field in this test case is updated using onInput on the first field.
The third field is updated using setTimeout to demonstrate a workaround.
1. Type #,BKSP,#,BKSP,#,BKSP,#,BKSP,#,BKSP
2. Type ^Z 10 times
3. Type ^Y 10 times
4. Type ^Z 10 times
Updated•22 years ago
|
Priority: -- → P2
Target Milestone: --- → Future
Updated•21 years ago
|
Summary: Strange undo/redo interaction with oninput handlers → strange characters in message composer title/subject (was Strange undo/redo interaction with oninput handlers)
Comment 3•21 years ago
|
||
*** Bug 221829 has been marked as a duplicate of this bug. ***
Comment 4•21 years ago
|
||
Why hasn't this been fixed yet?
Reporter | ||
Comment 5•20 years ago
|
||
*** Bug 276647 has been marked as a duplicate of this bug. ***
Updated•18 years ago
|
QA Contact: sujay → editor
Updated•18 years ago
|
Assignee: kinmoz → nobody
Comment 6•17 years ago
|
||
WFM instructions in comment 2 - Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a8pre) Gecko/2007081503 SeaMonkey/2.0a1pre
Reporter | ||
Comment 7•17 years ago
|
||
(In reply to comment #6)
>WFM instructions in comment 2 - Mozilla/5.0 (Windows; U; Windows NT 5.1;
>en-US; rv:1.9a8pre) Gecko/2007081503 SeaMonkey/2.0a1pre
Odd, because comment 2 is still broken for me, although comment 1 is WFM now.
Comment 8•17 years ago
|
||
Assignee | ||
Comment 9•16 years ago
|
||
This may be related to bug 318065...
Reporter | ||
Comment 10•16 years ago
|
||
I'm not surprised, as both bugs are set to block bug 318355.
I wanted to try the patch on bug 318065 but it seems to have bitrotted...
Assignee | ||
Comment 11•16 years ago
|
||
> I wanted to try the patch on bug 318065 but it seems to have bitrotted...
Heh, it was another patch of mine that bitrotted it. Updated patch posted in the bug...
Reporter | ||
Comment 12•16 years ago
|
||
It almost completely fixes all the cases except one: if you hit Undo on a new field, then the value silently changes to a newline (presumably the bogus BR node stops being bogus for some reason) although no input event is generated (the problem will show up more obviously after subsequent input).
Assignee | ||
Comment 13•16 years ago
|
||
> It almost completely fixes all the cases except one: if you hit Undo on a new
> field, then the value silently changes to a newline (presumably the bogus BR
> node stops being bogus for some reason) although no input event is generated
> (the problem will show up more obviously after subsequent input).
That sounds like 471319 / 471776
Reporter | ||
Comment 14•16 years ago
|
||
Maybe, but I don't see how emptytext is involved. Or is that just a symptom?
Assignee | ||
Comment 15•16 years ago
|
||
>That sounds like 471319 / 471776
Definitely 471319
> Maybe, but I don't see how emptytext is involved. Or is that just a symptom?
Yes, for this case it's not involved - I've found that 471319 isn't really specific to emptytext or batched editing transactions, it's a more general problem.
The editor post undo/redo code assumes that something interesting will happen during undo/redo: if you had a bogus node pre-undo/redo, it assumes there will have been text inserted, and marks the node as not bogus afterwards.
Assignee | ||
Comment 16•12 years ago
|
||
I think this was fixed long ago by a combination of bugs 318065 and 471319.
Can anyone confirm?
Updated•12 years ago
|
Component: Editor → Composer
Product: Core → SeaMonkey
Reporter | ||
Comment 17•12 years ago
|
||
Seems fixed to me.
Assignee: nobody → graememcc_firefox
Status: NEW → RESOLVED
Closed: 12 years ago
Component: Composer → Editor
Product: SeaMonkey → Core
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•