Open
Bug 1476422
Opened 6 years ago
Updated 2 years ago
Remove MinGW workaround for wmain
Categories
(Firefox :: General, enhancement, P3)
Tracking
()
NEW
Tracking | Status | |
---|---|---|
firefox63 | --- | affected |
People
(Reporter: bugzilla, Unassigned)
References
Details
Attachments
(1 file)
(deleted),
patch
|
away
:
feedback+
|
Details | Diff | Splinter Review |
mingw now supports wmain provided that:
1) It is defined with extern "C"; and
2) -municode is added to LDFLAGS
Let's get rid of the workaround added in bug 411826 and enable -municode.
Reporter | ||
Comment 1•6 years ago
|
||
Attachment #8992766 -
Flags: review?(dmajor)
Comment on attachment 8992766 [details] [diff] [review]
Remove mingw wmain hackery and add -municode to all binaries that need it
I support this change but I'd feel better if glandium had a look.
Attachment #8992766 -
Flags: review?(mh+mozilla)
Attachment #8992766 -
Flags: review?(dmajor)
Attachment #8992766 -
Flags: feedback+
Updated•6 years ago
|
Priority: -- → P1
Comment 3•6 years ago
|
||
Comment on attachment 8992766 [details] [diff] [review]
Remove mingw wmain hackery and add -municode to all binaries that need it
Review of attachment 8992766 [details] [diff] [review]:
-----------------------------------------------------------------
This seems like something that should be done more centrally for all programs (build/templaces.mozbuild or build/gecko_templates.mozbuild, maybe?), and not limited to gcc (there's work underway to support mingw-clang, and I suspect this breaks it).
Attachment #8992766 -
Flags: review?(mh+mozilla)
Reporter | ||
Comment 4•6 years ago
|
||
Not all programs currently use wmain, so we'll have to do a mass s/main/wmain/. This patch just handled the ones that already used it.
Reporter | ||
Comment 5•6 years ago
|
||
I'm going to de-assign myself for now; this is expanding into more work than I am willing to spend time on.
Assignee: aklotz → nobody
Status: ASSIGNED → NEW
Priority: P1 → P3
Comment 6•6 years ago
|
||
If only a few programs are using wmain, then it's fine. Just please don't break mingw-clang.
Updated•2 years ago
|
Severity: normal → S3
You need to log in
before you can comment on or make changes to this bug.
Description
•