STR: - Open storage inspector on https://wwwhome.ewi.utwente.nl/~vriezekolke/test.html - Resize the toolbox to be higher - scroll down the local storage tab AR: nothing happens ER: more items should display I'm guessing it's because with the logic at [0] expects the user to be able to scroll 9/10 of the scroll height, which isn't possible if the scrollbar is too short. [0]: https://searchfox.org/mozilla-central/rev/c296d5b2391c8b37374b118180b64cca66c0aa16/devtools/client/shared/widgets/TableWidget.js#1011

Julian, it looks like your patch in bug 1434579 would fix this. Would it be possible to split out the relevant part here ?

Comment on attachment 8993024 [details] Bug 1476647 - Fix TableWidget scroll position calculation; https://reviewboard.mozilla.org/r/257828/#review264756

Thanks for the review. Green try at https://treeherder.mozilla.org/#/jobs?repo=try&revision=dcf7f9a8d1e2d585a37bad799fd3b31ecdbb0b5b Landing.

Pushed by jdescottes@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/627f2adec73b Fix TableWidget scroll position calculation;r=miker

Backed out changeset 627f2adec73b (bug 1476647) for causing failures in devtools/client/storage/test/browser_storage_overflow.js Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=627f2adec73bfe730ffe52b24dcfbae813860190&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=usercancel&filter-resultStatus=runnable&selectedJob=188875821 Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=188875821&repo=autoland&lineNumber=1808 Backout push: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=c2ac7299fa0e64d7c02141ff16d81d8cb263c8f2&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=usercancel&filter-resultStatus=runnable

Sorry about that! Switching to vertical layout for the storage inspector seems to make the test fail intermittently. Since the bug can be reproduced simply using a bigger height for DevTools, I will update it to do that.

Pushed by jdescottes@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/25c83a66f294 Fix TableWidget scroll position calculation;r=miker