Closed Bug 1476684 Opened 6 years ago Closed 6 years ago

Onboarding shouldn't be affected by snippets, experiment prefs

Categories

(Firefox :: Messaging System, enhancement, P1)

enhancement

Tracking

()

RESOLVED FIXED
Firefox 63
Iteration:
63.5 - Sep 3
Tracking Status
firefox63 --- fixed

People

(Reporter: k88hudson, Assigned: ursula)

References

(Blocks 2 open bugs)

Details

Attachments

(1 file)

Currently the new onboarding experience does not show up if the snippets pref (as well as the asrouter experiment pref) is set to false; we should ensure it is not tied to this pref, and remove any other obsolete prefs, when landing this for release.
Assignee: nobody → usarracini
Iteration: --- → 63.3 - Aug 6
As discussed with Kate, here's the approach we're going to take to try and not only separate onboarding pref from snippets, but also in general try to consolidate some of these asrouter prefs: 1. add an 'enabled' field to each of the providers in browser.newtabpage.activity-stream.asrouter.messageProviders (false by default) + an additional 'cohort' field to the onboarding provider. this cohort field will hold the integer that shield will target for different cohorts for future onboarding experiments. this allows us to remove asrouterOnboardingCohort pref 2. move the initialization of asrouter content out of snippets.js 3. change snippets.js to initialize old snippets check against browser.newtabpage.activity-stream.asrouter.messageProviders.snippets.enabled pref 4. change onboarding targeting JEXL expression to check browser.newtabpage.activity-stream.asrouter.messageProviders.onboarding.cohort
Blocks: 1471328
Iteration: 63.3 - Aug 6 → 63.5 - Sep 3
Priority: P2 → P1
Commits pushed to master at https://github.com/mozilla/activity-stream https://github.com/mozilla/activity-stream/commit/4ad851b3bc9ab6eac25b09d238e5276ef9b674e9 Fix Bug 1476684 - Onboarding shouldn't be affected by snippets, experiment prefs https://github.com/mozilla/activity-stream/commit/248ff08f6cac5380bdc84d79148539ce1b217d64 Merge pull request #4338 from sarracini/bug_1476684 Fix Bug 1476684 - Onboarding shouldn't be affected by snippets experiment prefs
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Blocks: 1487538
Component: Activity Streams: Newtab → Messaging System
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: