Closed
Bug 1476753
Opened 6 years ago
Closed 5 years ago
Port |Bug 1476639 Remove scrollToIndex|
Categories
(Thunderbird :: General, task)
Thunderbird
General
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 75.0
People
(Reporter: jorgk-bmo, Assigned: darktrojan)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
pmorris
:
review+
|
Details | Diff | Splinter Review |
|
||
Updated•5 years ago
|
Type: enhancement → task
|
Reporter | |
Comment 1•5 years ago
|
||
Sadly one paid attention to bug 1476639 which is now on autoland.
|
Assignee | |
Updated•5 years ago
|
Assignee: nobody → geoff
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 2•5 years ago
|
||
I'm sure this is fine but when I did a Try run I foolishly didn't include the changes to m-c. Doing another one now to see if anything surfaces.
Attachment #9129659 -
Flags: review?(paul)
|
|
Reporter | |
Comment 3•5 years ago
|
||
Comment on attachment 9129659 [details] [diff] [review]
1476753-scrolltoindex-1.diff
This should land **NOW** or Daily will be busted.
Attachment #9129659 -
Flags: review?(mkmelin+mozilla)
|
||
Comment 4•5 years ago
|
||
Comment on attachment 9129659 [details] [diff] [review]
1476753-scrolltoindex-1.diff
Review of attachment 9129659 [details] [diff] [review]:
-----------------------------------------------------------------
The changes look good and follow what was recommended in bug 1476639.
Try run looks good: https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=004eedae70845e1c031630b2018c4a458c1093ea
Attachment #9129659 -
Flags: review?(paul) → review+
|
|
||
Updated•5 years ago
|
Summary: Port |Bug 1476639 Remove scrollToIndex and scrollToElement| → Port |Bug 1476639 Remove scrollToIndex|
|
||
Updated•5 years ago
|
Keywords: checkin-needed-tb
Target Milestone: --- → Thunderbird 75.0
|
|
||
Comment 5•5 years ago
|
||
Comment on attachment 9129659 [details] [diff] [review]
1476753-scrolltoindex-1.diff
Yeah should land once the bustage is fixed.
Attachment #9129659 -
Flags: review?(mkmelin+mozilla)
Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/576c40b52ef8
Port bug 1476639 - Remove scrollToIndex. r=pmorris
You need to log in
before you can comment on or make changes to this bug.
Description
•