Closed
Bug 1476846
Opened 6 years ago
Closed 6 years ago
Reduce latency of applying async images of video
Categories
(Core :: Graphics: WebRender, enhancement, P3)
Core
Graphics: WebRender
Tracking
()
RESOLVED
FIXED
mozilla63
Tracking | Status | |
---|---|---|
firefox63 | --- | fixed |
People
(Reporter: sotaro, Assigned: sotaro)
References
(Blocks 1 open bug)
Details
Attachments
(2 files, 1 obsolete file)
(deleted),
patch
|
sotaro
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
sotaro
:
review+
|
Details | Diff | Splinter Review |
async images of video is applied with latency with async scene build. It is better to reduce the latency.
Assignee | ||
Comment 1•6 years ago
|
||
Assignee | ||
Comment 2•6 years ago
|
||
Assignee | ||
Updated•6 years ago
|
Attachment #8993219 -
Flags: review?(nical.bugzilla)
Updated•6 years ago
|
Attachment #8993219 -
Flags: review?(nical.bugzilla) → review+
Comment hidden (obsolete) |
Assignee | ||
Updated•6 years ago
|
Attachment #8995854 -
Flags: review+
Comment hidden (obsolete) |
Updated•6 years ago
|
Priority: -- → P3
Assignee | ||
Comment 6•6 years ago
|
||
Pushed by sikeda@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/738e88d3b78e
Reduce latency of applying async images of video r=nical
Comment 8•6 years ago
|
||
Comment on attachment 8995854 [details] [diff] [review]
patch - Reduce latency of applying async images of video
Review of attachment 8995854 [details] [diff] [review]:
-----------------------------------------------------------------
::: gfx/layers/wr/AsyncImagePipelineManager.cpp
@@ +355,5 @@
> // We may, however, have updated some resources.
> +
> + // Use transaction of scene builder thread to notify epoch.
> + // It is for making epoc update consisitent.
> + aMaybeFastTxn.UpdateEpoch(aPipelineId, aEpoch);
This part doesn't seem right. The comment says you're using the scene builder transaction, but the code is using the fast transaction which goes on the RB thread. Also typos: s/epoc/epoch/ and s/consisitent/consistent/
Comment 10•6 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox63:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
Assignee | ||
Updated•6 years ago
|
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee | ||
Comment 12•6 years ago
|
||
Assignee | ||
Comment 13•6 years ago
|
||
Assignee | ||
Updated•6 years ago
|
Attachment #8998381 -
Flags: review+
Comment 14•6 years ago
|
||
Pushed by sikeda@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/aab1cac9daa8
Fix UpdateEpoch() handling r=nical
Comment 15•6 years ago
|
||
bugherder |
Status: REOPENED → RESOLVED
Closed: 6 years ago → 6 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•