Closed
Bug 1477296
Opened 6 years ago
Closed 6 years ago
Storage inspector item deletion should update item scrolling offset
Categories
(DevTools :: Storage Inspector, defect, P2)
DevTools
Storage Inspector
Tracking
(firefox67 fixed)
RESOLVED
FIXED
Firefox 67
| Tracking | Status | |
|---|---|---|
| firefox67 | --- | fixed |
People
(Reporter: ntim, Assigned: rfgo, Mentored)
References
Details
(Keywords: good-first-bug, Whiteboard: [qa-67b-p2])
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
STR:
- Open storage inspector on https://wwwhome.ewi.utwente.nl/~vriezekolke/test.html
- scroll until all items are displayed
- click "clear localStorage"
- open split console and paste:
for (var i=0; i<200; i++) {
var s = ("00"+i).slice(-3);
localStorage["Key"+s] = "Value "+i;
console.debug("Storing key [Key"+s+"] with value [Value "+i+"]");
}
- try scrolling the storage inspector again
Items are not revealed.
This is because the itemOffset at [0] is not updated when the items are cleared.
[0]: https://searchfox.org/mozilla-central/source/devtools/client/storage/ui.js#1094
So we need to reset the offset when it is higher than the number of storage items.
Mentor: mratcliffe
Has STR: --- → yes
Keywords: good-first-bug
OS: Unspecified → All
Priority: -- → P2
Hardware: Unspecified → All
|
Assignee | |
Comment 2•6 years ago
|
||
Assignee: nobody → rainier.f.go
Status: NEW → ASSIGNED
Pushed by mratcliffe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9a21f8e89b15
Updated itemoffset to 0 when local storage is cleared r=miker
|
||
Comment 4•6 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox67:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 67
|
||
Updated•6 years ago
|
Whiteboard: [qa-67b-p2]
You need to log in
before you can comment on or make changes to this bug.
Description
•