This bug was filed from the Socorro interface and is report bp-690885bc-8a5c-4a0f-b68d-6c40f0180720. ============================================================= Top 10 frames of crashing thread: 0 libxul.so mozilla::widget::GeckoEditableSupport::DoReplaceText dom/events/TextComposition.h:127 1 libxul.so mozilla::widget::GeckoEditableSupport::OnImeReplaceText widget/android/GeckoEditableSupport.cpp:976 2 libxul.so mozilla::EnableIf< const widget/android/jni/Natives.h:438 3 libxul.so mozilla::jni::detail::ProxyNativeCall<mozilla::widget::GeckoEditableSupport, mozilla::java::GeckoEditableChild, false, false, int, int, mozilla::jni::StringParam const&>::operator widget/android/jni/Natives.h:499 4 libxul.so nsAppShell::ProcessNextNativeEvent widget/android/nsAppShell.cpp:754 5 libxul.so nsBaseAppShell::DoProcessNextNativeEvent widget/nsBaseAppShell.cpp:140 6 libxul.so nsBaseAppShell::OnProcessNextEvent widget/nsBaseAppShell.cpp:291 7 libxul.so non-virtual thunk to nsBaseAppShell::OnProcessNextEvent widget/nsBaseAppShell.cpp 8 libxul.so nsThread::ProcessNextEvent xpcom/threads/nsThread.cpp:1083 9 libxul.so NS_ProcessNextEvent xpcom/threads/nsThreadUtils.cpp:519 ============================================================= There is 1 crash in nightly 63 with buildid 20180720101506. In analyzing the backtrace, the regression may have been introduced by patch [1] to fix bug 1470786. [1] https://hg.mozilla.org/mozilla-central/rev?node=d4c93d40e9aa

Comment on attachment 8994680 [details] Bug 1477469 - Check for null composition pointer; https://reviewboard.mozilla.org/r/259194/#review266474

Pushed by nchen@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/068426dfbe61 Check for null composition pointer; r=esawin

Comment on attachment 8994680 [details] Bug 1477469 - Check for null composition pointer; Approval Request Comment [Feature/Bug causing the regression]: Bug 1470786 [User impact if declined]: Possible rare crash [Is this code covered by automated tests?]: No [Has the fix been verified in Nightly?]: No [Needs manual test from QE? If yes, steps to reproduce]: No [List of other uplifts needed for the feature/fix]: None [Is the change risky?]: No [Why is the change risky/not risky?]: Only change is to avoid cases where we would end up crashing. [String changes made/needed]: None

Comment on attachment 8994680 [details] Bug 1477469 - Check for null composition pointer; While we haven't seen these crashes in 62, seems like a null check should not hurt (and it may just be a super rare crash). Let's uplift for beta 13.