Closed Bug 1477551 Opened 6 years ago Closed 6 years ago

Bullet Points are cut-off in gmail's editor with WR and scaling at 140%

Categories

(Core :: Graphics: WebRender, defect, P2)

Product:
Core
Component:
Graphics: WebRender
Version:
63 Branch
Platform:
x86_64
Linux
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla64
Tracking Flags:
Tracking Status
firefox64 --- fixed

People

(Reporter: linuxhippy, Assigned: emilio)

References

(Blocks 2 open bugs,
URL
)

Details

(Keywords: correctness, nightly-community)

Attachments

(4 files)

screenshot "old" opengl backend
(deleted), image/png
Details
bullet points with WR enabled
(deleted), image/png
Details
testcase.html
(deleted), text/html
Details
Bug 1477551 - Ensure the clip and the rect that we push for bullets agree.
(deleted), text/x-phabricator-request
jrmuizel
: review+
Details
User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:63.0) Gecko/20100101 Firefox/63.0 Build ID: 20180722100230 Steps to reproduce: when running firefox with WebRender enabled and scaling set to 140%, bullet points in gmail's editor are cut off (does not happen with the "old" opengl backend). Depending on the scaling factor the points are cut off at different edges. E.g. at 140% they are cut off right, whereas at 150% the bottom edge is cut off. System info: Extended renderer info (GLX_MESA_query_renderer): Vendor: X.Org (0x1002) Device: AMD KAVERI (DRM 3.25.0 / 4.17.6-200.fc28.x86_64, LLVM 6.0.0) (0x1313) Version: 18.0.5 Accelerated: yes Video memory: 844MB Unified memory: no Preferred profile: core (0x1) Max core profile version: 4.5 Max compat profile version: 3.0 Max GLES1 profile version: 1.1 Max GLES[23] profile version: 3.1
Attached image screenshot "old" opengl backend (deleted) —
Attached image bullet points with WR enabled (deleted) —
Component: Untriaged → Graphics: WebRender
Product: Firefox → Core
Blocks: webrender-site-issues
URL: https://mail.google.com/mail/u/0/#inb...
Status: UNCONFIRMED → NEW
Ever confirmed: true
Keywords: correctness, nightly-community
OS: Unspecified → Linux
Hardware: Unspecified → x86_64
Assignee: nobody → emilio
Priority: -- → P2
Attached file testcase.html (deleted) —
I couldn't reproduce at 140% zoom particularly, but this alone repros at different zoom levels. Also, if you edit the text it actually becomes much funnier, because of bug 1434006.
Attachment #9006564 - Attachment mime type: text/plain → text/html
(In reply to Emilio Cobos Álvarez (:emilio) from comment #4) > I couldn't repro this Err, ignore, this was half-written before I posted comment 3.
Using mPathRect causes rounding errors unnecessarily.
Comment on attachment 9008503 [details] Bug 1477551 - Ensure the clip and the rect that we push for bullets agree. Jeff Muizelaar [:jrmuizel] has approved the revision.
Attachment #9008503 - Flags: review+
Pushed by emilio@crisal.io: https://hg.mozilla.org/integration/autoland/rev/ef589916a739 Ensure the clip and the rect that we push for bullets agree. r=jrmuizel
Backed out changeset ef589916a739 (bug 1477551) for build bustage. CLOSED TREE Log: https://treeherder.mozilla.org/logviewer.html#?job_id=198943404&repo=autoland&lineNumber=23514 NFO - 15 warnings and 1 error generated. 21:51:19 INFO - z:/task_1536786470/build/src/config/rules.mk:1110: recipe for target 'Unified_cpp_widget_windows2.obj' failed 21:51:19 INFO - mozmake.EXE[4]: *** [Unified_cpp_widget_windows2.obj] Error 1 21:51:19 INFO - mozmake.EXE[4]: Leaving directory 'z:/task_1536786470/build/src/obj-firefox/widget/windows' 21:51:19 INFO - mozmake.EXE[4]: *** Waiting for unfinished jobs.... 21:51:19 INFO - mozmake.EXE[4]: Entering directory 'z:/task_1536786470/build/src/obj-firefox/layout/generic' 21:51:19 INFO - mozmake.EXE[4]: Leaving directory 'z:/task_1536786470/build/src/obj-firefox/layout/generic' 21:51:19 INFO - mozmake.EXE[4]: Entering directory 'z:/task_1536786470/build/src/obj-firefox/layout/generic' 21:51:19 INFO - mozmake.EXE[4]: Leaving directory 'z:/task_1536786470/build/src/obj-firefox/layout/generic' 21:51:23 INFO - mozmake.EXE[4]: Entering directory 'z:/task_1536786470/build/src/obj-firefox/widget/windows' 21:51:23 INFO - z:/task_1536786470/build/src/clang/bin/clang-cl.exe -fms-compatibility-version=19.13.26128 -FoUnified_cpp_widget_windows0.obj -c -Iz:/task_1536786470/build/src/obj-firefox/dist/stl_wrappers -DNDEBUG=1 -DTRIMMED=1 -DWIN32_LEAN_AND_MEAN -D_WIN32 -DWIN32 -D_CRT_RAND_S -DCERT_CHAIN_PARA_HAS_EXTRA_FIELDS -DOS_WIN=1 -D_UNICODE -DCHROMIUM_BUILD -DU_STATIC_IMPLEMENTATION -DUNICODE -D_WINDOWS -D_SECURE_ATL -DCOMPILER_MSVC -DMOZ_UNICODE -DSTATIC_EXPORTABLE_JS_API -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -Iz:/task_1536786470/build/src/widget/windows -Iz:/task_1536786470/build/src/obj-firefox/widget/windows -Iz:/task_1536786470/build/src/obj-firefox/ipc/ipdl/_ipdlheaders -Iz:/task_1536786470/build/src/ipc/chromium/src -Iz:/task_1536786470/build/src/ipc/glue -Iz:/task_1536786470/build/src/layout/generic -Iz:/task_1536786470/build/src/layout/xul -Iz:/task_1536786470/build/src/toolkit/xre -Iz:/task_1536786470/build/src/widget -Iz:/task_1536786470/build/src/widget/headless -Iz:/task_1536786470/build/src/xpcom/base -Iz:/task_1536786470/build/src/obj-firefox/dist/include -Iz:/task_1536786470/build/src/obj-firefox/dist/include/nspr -Iz:/task_1536786470/build/src/obj-firefox/dist/include/nss -MD -FI z:/task_1536786470/build/src/obj-firefox/mozilla-config.h -DMOZILLA_CLIENT -Qunused-arguments -Qunused-arguments -TP -nologo -w15038 -wd5026 -wd5027 -Zc:sizedDealloc- -wd4091 -wd4577 -D_HAS_EXCEPTIONS=0 -W3 -Gy -Zc:inline -Gw -wd4251 -wd4244 -wd4267 -wd4800 -wd4595 -wd4065 -Wno-inline-new-delete -Wno-invalid-offsetof -Wno-microsoft-enum-value -Wno-microsoft-include -Wno-unknown-pragmas -Wno-ignored-pragmas -Wno-deprecated-declarations -Wno-invalid-noreturn -Wno-inconsistent-missing-override -Wno-implicit-exception-spec-mismatch -Wno-unused-local-typedef -Wno-ignored-attributes -Wno-used-but-marked-unused -we4553 -D_SILENCE_TR1_NAMESPACE_DEPRECATION_WARNING -GR- -Zi -O2 -Oy- -Iz:/task_1536786470/build/src/obj-firefox/dist/include/cairo -Xclang -MP -Xclang -dependency-file -Xclang .deps/Unified_cpp_widget_windows0.obj.pp -Xclang -MT -Xclang Unified_cpp_widget_windows0.obj -Fdgenerated.pdb -FS z:/task_1536786470/build/src/obj-firefox/widget/windows/Unified_cpp_widget_windows0.cpp 21:51:23 INFO - mozmake.EXE[4]: Leaving directory 'z:/task_1536786470/build/src/obj-firefox/widget/windows' 21:51:23 INFO - mozmake.EXE[4]: Entering directory 'z:/task_1536786470/build/src/obj-firefox/layout/style' 21:51:23 INFO - mozmake.EXE[4]: Leaving directory 'z:/task_1536786470/build/src/obj-firefox/layout/style' 21:51:23 INFO - mozmake.EXE[4]: Entering directory 'z:/task_1536786470/build/src/obj-firefox/layout/style' 21:51:23 INFO - mozmake.EXE[4]: Leaving directory 'z:/task_1536786470/build/src/obj-firefox/layout/style' 21:51:23 INFO - mozmake.EXE[4]: Entering directory 'z:/task_1536786470/build/src/obj-firefox/widget/windows' 21:51:23 INFO - z:/task_1536786470/build/src/clang/bin/clang-cl.exe -fms-compatibility-version=19.13.26128 -FoUnified_cpp_widget_windows1.obj -c -Iz:/task_1536786470/build/src/obj-firefox/dist/stl_wrappers -DNDEBUG=1 -DTRIMMED=1 -DWIN32_LEAN_AND_MEAN -D_WIN32 -DWIN32 -D_CRT_RAND_S -DCERT_CHAIN_PARA_HAS_EXTRA_FIELDS -DOS_WIN=1 -D_UNICODE -DCHROMIUM_BUILD -DU_STATIC_IMPLEMENTATION -DUNICODE -D_WINDOWS -D_SECURE_ATL -DCOMPILER_MSVC -DMOZ_UNICODE -DSTATIC_EXPORTABLE_JS_API -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -Iz:/task_1536786470/build/src/widget/windows -Iz:/task_1536786470/build/src/obj-firefox/widget/windows -Iz:/task_1536786470/build/src/obj-firefox/ipc/ipdl/_ipdlheaders -Iz:/task_1536786470/build/src/ipc/chromium/src -Iz:/task_1536786470/build/src/ipc/glue -Iz:/task_1536786470/build/src/layout/generic -Iz:/task_1536786470/build/src/layout/xul -Iz:/task_1536786470/build/src/toolkit/xre -Iz:/task_1536786470/build/src/widget -Iz:/task_1536786470/build/src/widget/headless -Iz:/task_1536786470/build/src/xpcom/base -Iz:/task_1536786470/build/src/obj-firefox/dist/include -Iz:/task_1536786470/build/src/obj-firefox/dist/include/nspr -Iz:/task_1536786470/build/src/obj-firefox/dist/include/nss -MD -FI z:/task_1536786470/build/src/obj-firefox/mozilla-config.h -DMOZILLA_CLIENT -Qunused-arguments -Qunused-arguments -TP -nologo -w15038 -wd5026 -wd5027 -Zc:sizedDealloc- -wd4091 -wd4577 -D_HAS_EXCEPTIONS=0 -W3 -Gy -Zc:inline -Gw -wd4251 -wd4244 -wd4267 -wd4800 -wd4595 -wd4065 -Wno-inline-new-delete -Wno-invalid-offsetof -Wno-microsoft-enum-value -Wno-microsoft-include -Wno-unknown-pragmas -Wno-ignored-pragmas -Wno-deprecated-declarations -Wno-invalid-noreturn -Wno-inconsistent-missing-override -Wno-implicit-exception-spec-mismatch -Wno-unused-local-typedef -Wno-ignored-attributes -Wno-used-but-marked-unused -we4553 -D_SILENCE_TR1_NAMESPACE_DEPRECATION_WARNING -GR- -Zi -O2 -Oy- -Iz:/task_1536786470/build/src/obj-firefox/dist/include/cairo -Xclang -MP -Xclang -dependency-file -Xclang .deps/Unified_cpp_widget_windows1.obj.pp -Xclang -MT -Xclang Unified_cpp_widget_windows1.obj -Fdgenerated.pdb -FS z:/task_1536786470/build/src/obj-firefox/widget/windows/Unified_cpp_widget_windows1.cpp 21:51:23 INFO - mozmake.EXE[4]: Leaving directory 'z:/task_1536786470/build/src/obj-firefox/widget/windows' 21:51:23 INFO - mozmake.EXE[4]: Entering directory 'z:/task_1536786470/build/src/obj-firefox/layout/tables' 21:51:23 INFO - mkdir -p '.deps/' 21:51:23 INFO - mozmake.EXE[4]: Leaving directory 'z:/task_1536786470/build/src/obj-firefox/layout/tables' 21:51:23 INFO - mozmake.EXE[4]: Entering directory 'z:/task_1536786470/build/src/obj-firefox/layout/tables' 21:51:23 INFO - layout/tables 21:51:23 INFO - mozmake.EXE[4]: Leaving directory 'z:/task_1536786470/build/src/obj-firefox/layout/tables' 21:51:23 INFO - mozmake.EXE[4]: Entering directory 'z:/task_1536786470/build/src/obj-firefox/layout/tables' 21:51:23 INFO - mozmake.EXE[4]: Leaving directory 'z:/task_1536786470/build/src/obj-firefox/layout/tables' 21:51:24 INFO - mozmake.EXE[4]: Entering directory 'z:/task_1536786470/build/src/obj-firefox/layout/base' 21:51:24 INFO - z:/task_1536786470/build/src/clang/bin/clang-cl.exe -fms-compatibility-version=19.13.26128 -FoUnified_cpp_layout_base2.obj -c -Iz:/task_1536786470/build/src/obj-firefox/dist/stl_wrappers -DNDEBUG=1 -DTRIMMED=1 -DWIN32_LEAN_AND_MEAN -D_WIN32 -DWIN32 -D_CRT_RAND_S -DCERT_CHAIN_PARA_HAS_EXTRA_FIELDS -DOS_WIN=1 -D_UNICODE -DCHROMIUM_BUILD -DU_STATIC_IMPLEMENTATION -DUNICODE -D_WINDOWS -D_SECURE_ATL -DCOMPILER_MSVC -DSTATIC_EXPORTABLE_JS_API -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -Iz:/task_1536786470/build/src/layout/base -Iz:/task_1536786470/build/src/obj-firefox/layout/base -Iz:/task_1536786470/build/src/obj-firefox/ipc/ipdl/_ipdlheaders -Iz:/task_1536786470/build/src/ipc/chromium/src -Iz:/task_1536786470/build/src/ipc/glue -Iz:/task_1536786470/build/src/layout/forms -Iz:/task_1536786470/build/src/layout/generic -Iz:/task_1536786470/build/src/layout/mathml -Iz:/task_1536786470/build/src/layout/painting -Iz:/task_1536786470/build/src/layout/printing -Iz:/task_1536786470/build/src/layout/style -Iz:/task_1536786470/build/src/layout/svg -Iz:/task_1536786470/build/src/layout/tables -Iz:/task_1536786470/build/src/layout/xul -Iz:/task_1536786470/build/src/layout/xul/tree -Iz:/task_1536786470/build/src/docshell/base -Iz:/task_1536786470/build/src/dom/base -Iz:/task_1536786470/build/src/dom/html -Iz:/task_1536786470/build/src/dom/svg -Iz:/task_1536786470/build/src/dom/xbl -Iz:/task_1536786470/build/src/dom/xul -Iz:/task_1536786470/build/src/view -Iz:/task_1536786470/build/src/obj-firefox/dist/include -Iz:/task_1536786470/build/src/obj-firefox/dist/include/nspr -Iz:/task_1536786470/build/src/obj-firefox/dist/include/nss -MD -FI z:/task_1536786470/build/src/obj-firefox/mozilla-config.h -DMOZILLA_CLIENT -Qunused-arguments -Qunused-arguments -TP -nologo -w15038 -wd5026 -wd5027 -Zc:sizedDealloc- -wd4091 -wd4577 -D_HAS_EXCEPTIONS=0 -W3 -Gy -Zc:inline -Gw -wd4251 -wd4244 -wd4267 -wd4800 -wd4595 -wd4065 -Wno-inline-new-delete -Wno-invalid-offsetof -Wno-microsoft-enum-value -Wno-microsoft-include -Wno-unknown-pragmas -Wno-ignored-pragmas -Wno-deprecated-declarations -Wno-invalid-noreturn -Wno-inconsistent-missing-override -Wno-implicit-exception-spec-mismatch -Wno-unused-local-typedef -Wno-ignored-attributes -Wno-used-but-marked-unused -we4553 -D_SILENCE_TR1_NAMESPACE_DEPRECATION_WARNING -GR- -Zi -O2 -Oy- -WX -wd4312 -Xclang -MP -Xclang -dependency-file -Xclang .deps/Unified_cpp_layout_base2.obj.pp -Xclang -MT -Xclang Unified_cpp_layout_base2.obj -Fdgenerated.pdb -FS z:/task_1536786470/build/src/obj-firefox/layout/base/Unified_cpp_layout_base2.cpp 21:51:24 INFO - mozmake.EXE[4]: Leaving directory 'z:/task_1536786470/build/src/obj-firefox/layout/base' 21:51:24 INFO - mozmake.EXE[4]: Entering directory 'z:/task_1536786470/build/src/obj-firefox/widget/windows' 21:51:24 INFO - z:/task_1536786470/build/src/clang/bin/clang-cl.exe -fms-compatibility-version=19.13.26128 -FoUnified_cpp_widget_windows3.obj -c -Iz:/task_1536786470/build/src/obj-firefox/dist/stl_wrappers -DNDEBUG=1 -DTRIMMED=1 -DWIN32_LEAN_AND_MEAN -D_WIN32 -DWIN32 -D_CRT_RAND_S -DCERT_CHAIN_PARA_HAS_EXTRA_FIELDS -DOS_WIN=1 -D_UNICODE -DCHROMIUM_BUILD -DU_STATIC_IMPLEMENTATION -DUNICODE -D_WINDOWS -D_SECURE_ATL -DCOMPILER_MSVC -DMOZ_UNICODE -DSTATIC_EXPORTABLE_JS_API -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -Iz:/task_1536786470/build/src/widget/windows -Iz:/task_1536786470/build/src/obj-firefox/widget/windows -Iz:/task_1536786470/build/src/obj-firefox/ipc/ipdl/_ipdlheaders -Iz:/task_1536786470/build/src/ipc/chromium/src -Iz:/task_1536786470/build/src/ipc/glue -Iz:/task_1536786470/build/src/layout/generic -Iz:/task_1536786470/build/src/layout/xul -Iz:/task_1536786470/build/src/toolkit/xre -Iz:/task_1536786470/build/src/widget -Iz:/task_1536786470/build/src/widget/headless -Iz:/task_1536786470/build/src/xpcom/base -Iz:/task_1536786470/build/src/obj-firefox/dist/include -Iz:/task_1536786470/build/src/obj-firefox/dist/include/nspr -Iz:/task_1536786470/build/src/obj-firefox/dist/include/nss -MD -FI z:/task_1536786470/build/src/obj-firefox/mozilla-config.h -DMOZILLA_CLIENT -Qunused-arguments -Qunused-arguments -TP -nologo -w15038 -wd5026 -wd5027 -Zc:sizedDealloc- -wd4091 -wd4577 -D_HAS_EXCEPTIONS=0 -W3 -Gy -Zc:inline -Gw -wd4251 -wd4244 -wd4267 -wd4800 -wd4595 -wd4065 -Wno-inline-new-delete -Wno-invalid-offsetof -Wno-microsoft-enum-value -Wno-microsoft-include -Wno-unknown-pragmas -Wno-ignored-pragmas -Wno-deprecated-declarations -Wno-invalid-noreturn -Wno-inconsistent-missing-override -Wno-implicit-exception-spec-mismatch -Wno-unused-local-typedef -Wno-ignored-attributes -Wno-used-but-marked-unused -we4553 -D_SILENCE_TR1_NAMESPACE_DEPRECATION_WARNING -GR- -Zi -O2 -Oy- -Iz:/task_1536786470/build/src/obj-firefox/dist/include/cairo -Xclang -MP -Xclang -dependency-file -Xclang .deps/Unified_cpp_widget_windows3.obj.pp -Xclang -MT -Xclang Unified_cpp_widget_windows3.obj -Fdgenerated.pdb -FS z:/task_1536786470/build/src/obj-firefox/widget/windows/Unified_cpp_widget_windows3.cpp 21:51:24 INFO - In file included from z:/task_1536786470/build/src/obj-firefox/widget/windows/Unified_cpp_widget_windows3.cpp:2: 21:51:24 INFO - z:/task_1536786470/build/src/widget/windows/nsWindowGfx.cpp(129,1): warning: unused function 'EnsureSharedSurfaceSize' [-Wunused-function] 21:51:24 INFO - EnsureSharedSurfaceSize(IntSize size) 21:51:24 INFO - ^ 21:51:24 INFO - 1 warning generated. 21:51:24 INFO - mozmake.EXE[4]: Leaving directory 'z:/task_1536786470/build/src/obj-firefox/widget/windows' 21:51:24 INFO - z:/task_1536786470/build/src/config/recurse.mk:74: recipe for target 'widget/windows/target' failed 21:51:24 INFO - mozmake.EXE[3]: *** [widget/windows/target] Error 2 21:51:24 INFO - mozmake.EXE[3]: *** Waiting for unfinished jobs.... 21:51:24 INFO - mozmake.EXE[4]: Entering directory 'z:/task_1536786470/build/src/obj-firefox/layout/forms' 21:51:24 INFO - mozmake.EXE[4]: Leaving directory 'z:/task_1536786470/build/src/obj-firefox/layout/forms' 21:51:24 INFO - mozmake.EXE[4]: Entering directory 'z:/task_1536786470/build/src/obj-firefox/layout/generic' 21:51:24 INFO - mozmake.EXE[4]: Leaving directory 'z:/task_1536786470/build/src/obj-firefox/layout/generic' 21:51:24 INFO - mozmake.EXE[4]: Entering directory 'z:/task_1536786470/build/src/obj-firefox/layout/generic' 21:51:24 INFO - mozmake.EXE[4]: Leaving directory 'z:/task_1536786470/build/src/obj-firefox/layout/generic' 21:51:24 INFO - mozmake.EXE[4]: Entering directory 'z:/task_1536786470/build/src/obj-firefox/layout/forms' Push: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed,busted,exception&classifiedState=unclassified&group_state=expanded&selectedJob=198943404&revision=ef589916a7395d07a65c64fad5c1a607bb76bb42 Backout: https://hg.mozilla.org/integration/autoland/rev/0a6d1ff90dbac00c73ac31df4630c33d04c2da52
Flags: needinfo?(emilio)
Windows-only code :(
Flags: needinfo?(emilio)
Pushed by emilio@crisal.io: https://hg.mozilla.org/integration/autoland/rev/224045731c6f Ensure the clip and the rect that we push for bullets agree. r=jrmuizel
https://hg.mozilla.org/mozilla-central/rev/224045731c6f
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox64: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: