Closed
Bug 1477753
Opened 6 years ago
Closed 6 years ago
sharedData listener causes leaks in parent process when not removed manually
Categories
(Core :: IPC, enhancement)
Core
IPC
Tracking
()
RESOLVED
FIXED
mozilla63
Tracking | Status | |
---|---|---|
firefox63 | --- | fixed |
People
(Reporter: ntim, Assigned: kmag)
References
Details
Attachments
(1 file)
Example of leaks: https://treeherder.mozilla.org/#/jobs?repo=autoland&fromchange=f840add2cdd448ccb2a59d97c0ac6cbd967f038d&tochange=e207f210919a58c9032e3ea032ee1553194c8872&selectedJob=189514473&filter-searchStr=Linux%20x64%20asan%20Mochitests%20test-linux64-asan%2Fopt-mochitest-chrome-3%20M(c3) From Kris on IRC: We just don't clear the reference to the SharedMap early enough in the parent process
Comment hidden (mozreview-request) |
Reporter | ||
Updated•6 years ago
|
Assignee: nobody → kmaglione+bmo
Comment 2•6 years ago
|
||
mozreview-review |
Comment on attachment 8995369 [details] Bug 1477753: Implement missing cycle collection hooks for SharedMap. https://reviewboard.mozilla.org/r/259822/#review267060 ::: dom/ipc/SharedMap.h:326 (Diff revision 1) > > class WritableSharedMap final : public SharedMap > { > public: > + NS_DECL_ISUPPORTS_INHERITED > + NS_DECL_CYCLE_COLLECTION_SCRIPT_HOLDER_CLASS_INHERITED(WritableSharedMap, SharedMap) Can this be NS_DECL_CYCLE_COLLECTION_CLASS_INHERITED because you don't actually need to override the Trace() method?
Attachment #8995369 -
Flags: review?(continuation) → review+
Assignee | ||
Comment 3•6 years ago
|
||
mozreview-review-reply |
Comment on attachment 8995369 [details] Bug 1477753: Implement missing cycle collection hooks for SharedMap. https://reviewboard.mozilla.org/r/259822/#review267060 > Can this be NS_DECL_CYCLE_COLLECTION_CLASS_INHERITED because you don't actually need to override the Trace() method? I *think* so. I always forget the exact side-effects of that, so I tend to err on the safe side...
Comment hidden (mozreview-request) |
Pushed by maglione.k@gmail.com: https://hg.mozilla.org/integration/autoland/rev/411056404d23 Implement missing cycle collection hooks for SharedMap. r=mccr8
Comment 6•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/411056404d23
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox63:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in
before you can comment on or make changes to this bug.
Description
•