Closed
Bug 1477898
Opened 6 years ago
Closed 6 years ago
Stop calling EditorBase::SetFlags() from nsTextEditorState as far as possible
Categories
(Core :: DOM: Editor, defect)
Core
DOM: Editor
Tracking
()
RESOLVED
FIXED
mozilla63
| Tracking | Status | |
|---|---|---|
| firefox63 | --- | fixed |
People
(Reporter: masayuki, Assigned: masayuki)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
EditorBase::SetFlags() usually appears when I test attachment 8848015 [details]. However, it does nothing while the test. So, it must be caused by the cost of virtual calls even though nsTextEditorState never handles HTMLEditor (HTMLEditor is the only one which overrides EditorBase::SetFlags()).
Fortunately, EditorBase::Flags() must be an inline method. So, nsTextEditorState can check if it should call SetFlags().
| Comment hidden (mozreview-request) |
|
||
Comment 2•6 years ago
|
||
| mozreview-review | ||
Comment on attachment 8994391 [details]
Bug 1477898 - Make AutoRestoreEditorState not call EditorBase::SetFlags() since the virtual call cost appears in profile
https://reviewboard.mozilla.org/r/258958/#review266240
Attachment #8994391 -
Flags: review?(m_kato) → review+
Pushed by masayuki@d-toybox.com:
https://hg.mozilla.org/integration/autoland/rev/4d3ed6d8b874
Make AutoRestoreEditorState not call EditorBase::SetFlags() since the virtual call cost appears in profile r=m_kato
|
||
Comment 4•6 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in
before you can comment on or make changes to this bug.
Description
•