Closed
Bug 1478275
Opened 6 years ago
Closed 6 years ago
Stop using js::GetGlobalForObjectCrossCompartment in Xray code
Categories
(Core :: XPConnect, enhancement)
Core
XPConnect
Tracking
()
RESOLVED
FIXED
mozilla63
Tracking | Status | |
---|---|---|
firefox63 | --- | fixed |
People
(Reporter: jandem, Assigned: jandem)
References
Details
Attachments
(3 files)
(deleted),
patch
|
bholley
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
bholley
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
bholley
:
review+
|
Details | Diff | Splinter Review |
We have two GetGlobalForObjectCrossCompartment calls on Xray wrappers, but fortunately they are easy to fix.
Assignee | ||
Comment 1•6 years ago
|
||
Attachment #8994769 -
Flags: review?(bzbarsky)
Assignee | ||
Comment 2•6 years ago
|
||
Wrappers are per-compartment, not per-realm, so this will simplify the next patch. Also, considering the upcoming Realms proposal, it might eventually be possible to have multiple globals in a sandbox compartment.
Attachment #8994770 -
Flags: review?(bzbarsky)
Assignee | ||
Comment 3•6 years ago
|
||
Attachment #8994771 -
Flags: review?(bzbarsky)
Updated•6 years ago
|
Attachment #8994769 -
Flags: review?(bzbarsky) → review+
Updated•6 years ago
|
Attachment #8994770 -
Flags: review?(bzbarsky) → review+
Updated•6 years ago
|
Attachment #8994771 -
Flags: review?(bzbarsky) → review+
Pushed by jandemooij@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/49dceb93cc0c
part 1 - Remove unused CompartmentPrivate::isAddonCompartment. r=bholley
https://hg.mozilla.org/integration/mozilla-inbound/rev/4cd7934210cc
part 2 - Add a CompartmentPrivate::isSandboxCompartment flag and xpc::IsInSandboxCompartment(obj). r=bholley
https://hg.mozilla.org/integration/mozilla-inbound/rev/450f74df066e
part 3 - Rename GlobalHasExclusiveExpandos to CompartmentHasExclusiveExpandos and make it use IsInSandboxCompartment. r=bholley
Comment 5•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/49dceb93cc0c
https://hg.mozilla.org/mozilla-central/rev/4cd7934210cc
https://hg.mozilla.org/mozilla-central/rev/450f74df066e
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox63:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
Updated•6 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•