Implement an adapter to store in and retrieve secrets from the Windows Credentials Manager.

OS key-store adapter for Windows Credential Manager. It looks like Windows doesn't allow locking the credential manager without locking the desktop. So `lock` and `unlock` are no-ops here. Depends on D2487.

Comment on attachment 8996238 [details] Bug 1478668 - windows key store adapter, r?keeler [:keeler] (use needinfo) has approved the revision. https://phabricator.services.mozilla.com/D2550

Pushed by franziskuskiefer@gmail.com: https://hg.mozilla.org/integration/autoland/rev/e80000bf992c windows key store adapter, r=keeler

Backed out changeset e80000bf992c (bug 1478668) for build bustage Log: https://treeherder.mozilla.org/logviewer.html#?job_id=191311150&repo=autoland&lineNumber=53275 Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=e80000bf992c593b9980b500c35094032126aa9d&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-classifiedState=unclassified Backout: https://hg.mozilla.org/integration/autoland/rev/a1ce51fcdaa3bcd5f26c6bba729a993f59c68745

Well, if phab only had a try...

Pushed by franziskuskiefer@gmail.com: https://hg.mozilla.org/integration/autoland/rev/b5399f9627bc windows key store adapter, r=keeler

The error handling in StoreSecret and DeleteSecret is missing a return.

(In reply to Tom Schuster [:evilpie] from comment #8) > The error handling in StoreSecret and DeleteSecret is missing a return. Franziskus - r=me if you want to push a follow-up with those fixed (I'm surprised the compiler didn't warn/treat the warning as an error about this...)

yeah.. I'm not sure how that slipped through. I'll push a follow-up. Thanks Tom for reporting.

Pushed by franziskuskiefer@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/1c455445bc10 follow-up fixing error-case returns, r=keeler

This reduce some of the compiler warnings from Windows: == Change summary for alert #14783 (as of Tue, 07 Aug 2018 05:18:00 GMT) == Improvements: 0% compiler warnings windows2012-32 debug static-analysis 920.00 -> 918.00 0% compiler warnings windows2012-32 opt static-analysis 926.00 -> 924.00 0% compiler warnings windows2012-64 asan debug 918.00 -> 916.00 0% compiler warnings windows2012-64 asan opt 927.00 -> 925.00 0% compiler warnings windows2012-32 opt rusttests 917.00 -> 915.00 0% compiler warnings windows2012-32-noopt debug 909.00 -> 907.00 0% compiler warnings windows2012-32 pgo 917.00 -> 915.00 0% compiler warnings windows2012-32 debug 909.00 -> 907.00 0% compiler warnings windows2012-32 opt 917.00 -> 915.00 0% compiler warnings windows2012-64 debug static-analysis 947.00 -> 945.00 0% compiler warnings windows2012-64 opt static-analysis 953.00 -> 951.00 0% compiler warnings windows2012-64 opt plain 953.00 -> 951.00 0% compiler warnings windows2012-64 debug plain 943.00 -> 941.00 0% compiler warnings windows2012-64 opt rusttests 953.00 -> 951.00 0% compiler warnings windows2012-64 pgo 953.00 -> 951.00 0% compiler warnings windows2012-64 opt 953.00 -> 951.00 0% compiler warnings windows2012-64 debug 945.00 -> 943.00 For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=14783

(In reply to [:keeler] (use needinfo) from comment #9) > (I'm surprised the compiler didn't warn/treat the warning as an error about this...) clang-cl did warn, but -Werror for clang-cl is disabled on a large number of directories, including security/manager/ssl/, because we're not warning-clean with that compiler yet. (We do have -Werror on the MSVC builds, but I guess MSVC doesn't warn about this particular code pattern.) If you'd like to help get -Werror re-enabled for your modules faster, any assistance on bug 1481511 would be appreciated!