[:MakeMyDay] Reporter
	Description • 6 years ago

The dialog for editing custom reminder rules doesn'z show the box of defined reminders anymore. No message in the error log - adding an remiving of reminders there seems to work, though.

The dialog for editing custom recurrence rules is disfunctional to set up a complete custom rule. All the minimonth widgets are not displyed anymore for any of the recurrence types. Monthly recurrences is even more broken. Error console is complaining about |XUL box for hbox element contained an inline daypicker child, forcing all its children to be wrapped in a block|.

Both dialog can be opened from the respective drop down controls in the event tab/dialog window. To circumvent bug 1476947 the patch from that bug was applied.

Works as expected in ESR60 b10 and none of the currently queued patches fixes the issue. 

I'm not sure whether this is realy a fallout form the wx conversion or another regression.

	Geoff Lankow (:darktrojan) Assignee
	Comment 1 • 6 years ago

Does this fix your recurrence dialog?

	[:MakeMyDay] Reporter
	Comment 2 • 6 years ago

Thanks for looking at it - this fixes it partly - the controls in the custom reminder dialog are back with this applied, while the recurrence-preview (which diplays several minimonth widgets) is still missing at the bottom of the dialog.

The custom reminder dialog is not fixed by this, the reminder-listbox is still not displayed (which makes it likely that at least this is a regression of the listbox conversion and not related to the wx conversion).

You can compare the expected shape of the dialogs also with 60b10 if you have that at hand.

	Geoff Lankow (:darktrojan) Assignee
	Comment 3 • 6 years ago

They look okay here, can you post screenshots?

	[:MakeMyDay] Reporter
	Comment 4 • 6 years ago

Sure.

	Geoff Lankow (:darktrojan) Assignee
	Comment 5 • 6 years ago

Just make the dialogs taller. I'll mark the squashed parts with a minimum size so this doesn't happen again.

	Geoff Lankow (:darktrojan) Assignee
	Comment 6 • 6 years ago

Better?

	[:MakeMyDay] Reporter
	Comment 7 • 6 years ago

Comment on attachment 8995917 [details] [diff] [review]
1478989-recurrence-2.diff

Review of attachment 8995917 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks, works perfectly. But please revisit the location of the css definition.

::: calendar/base/content/dialogs/calendar-event-dialog-recurrence.xul
@@ +507,5 @@
>    <!-- preview -->
>    <groupbox id="preview-border" flex="1">
> +    <caption id="recurrence-preview-label"
> +             label="&event.recurrence.preview.label;"/>
> +    <recurrence-preview id="recurrence-preview" flex="1" style="min-height: 148px;"/>

Can you please move the css definition either into calendar/base/themes/{OS}/dialogs/calendar-event-dialog.css, which is already included referenced in this file or - since it is the same for all platforms - into calendar/base/themes/common/dialogs/calendar-event-dialog.css and include loading chrome://calendar-common/skin/dialogs/calendar-event-dialog.css into this file then?

::: calendar/base/content/dialogs/calendar-event-dialog-reminder.xul
@@ +33,5 @@
>                   seltype="single"
>                   class="event-dialog-listbox"
>                   onselect="onReminderSelected()"
> +                 flex="1"
> +                 style="min-height: 100px;"/>

Can you please move the css definition into the reminder dialog section in to calendar/base/themes/common/calendar-alarms.css instead?

	Geoff Lankow (:darktrojan) Assignee
	Comment 8 • 6 years ago

I decided to set the height of the recurrence preview at runtime, since it depends on the size of the font Thunderbird decides to use and some other peculiarities. Also that means if somebody changes the minimonth they don't have to update a bunch of stylesheets they might not know about.

	Geoff Lankow (:darktrojan) Assignee
	Comment 9 • 6 years ago

… and there's a linting error. I should learn to check these things.

	Pulsebot
	Comment 10 • 6 years ago

Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/a0852e1d7ad8
Fix broken widgets in event recurrence/reminder dialogs. r=philipp