Closed
Bug 1479021
Opened 6 years ago
Closed 6 years ago
Add support for URL-based parameters in provider endpoint
Categories
(Firefox :: Messaging System, enhancement, P2)
Firefox
Messaging System
Tracking
()
Tracking | Status | |
---|---|---|
firefox63 | --- | fixed |
People
(Reporter: k88hudson, Assigned: ahillier)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
(deleted),
text/x-github-pull-request
|
Details |
The legacy snippets implementation allows for the replacement of several values according to release channel, version, locale, and several others via the browser.aboutHomeSnippets.updateUrl pref:
https://snippets.allizom.org/%STARTPAGE_VERSION%/%NAME%/%VERSION%/%APPBUILDID%/%BUILD_TARGET%/%LOCALE%/%CHANNEL%/%OS_VERSION%/%DISTRIBUTION%/%DISTRIBUTION_VERSION%/
We should allow for this in provider endpoints as well in ASR since snippets will continue to support this.
Reporter | ||
Comment 1•6 years ago
|
||
Are all of these parameters in the URL still used/needed by the snippets service or only some?
Flags: needinfo?(giorgos)
Priority: -- → P2
Assignee | ||
Updated•6 years ago
|
Assignee: nobody → ahillier
Comment 2•6 years ago
|
||
(In reply to Kate Hudson :k88hudson from comment #1)
> Are all of these parameters in the URL still used/needed by the snippets
> service or only some?
Used always:
- startpage
- locale
- channel
Other fields that have been used:
- Name
- Version
- AppbuildID
- OS Version
What's the reasoning behind changing what we have?
Flags: needinfo?(giorgos)
Reporter | ||
Updated•6 years ago
|
Iteration: --- → 63.3 - Aug 6
Reporter | ||
Updated•6 years ago
|
Severity: normal → enhancement
Comment 3•6 years ago
|
||
Comment 4•6 years ago
|
||
Commit pushed to master at https://github.com/mozilla/activity-stream
https://github.com/mozilla/activity-stream/commit/0427d3aa62fc98b4eb0315aa642258984c7c5d22
Bug 1479021: support url params in provider endpoints (#4284)
Reporter | ||
Updated•6 years ago
|
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Comment 5•6 years ago
|
||
status-firefox63:
--- → fixed
Target Milestone: --- → Firefox 63
Updated•5 years ago
|
Component: Activity Streams: Newtab → Messaging System
You need to log in
before you can comment on or make changes to this bug.
Description
•