Closed
Bug 1479314
Opened 6 years ago
Closed 6 years ago
Pausing media playback through media control notification causes notification to momentarily disappear
Categories
(Firefox for Android Graveyard :: Audio/Video, defect)
Firefox for Android Graveyard
Audio/Video
Tracking
(firefox61 unaffected, firefox62 unaffected, firefox63+ verified)
VERIFIED
FIXED
Firefox 63
Tracking | Status | |
---|---|---|
firefox61 | --- | unaffected |
firefox62 | --- | unaffected |
firefox63 | + | verified |
People
(Reporter: JanH, Assigned: vlad.baicu)
References
Details
(Keywords: regression, Whiteboard: --do_not_change--[priority:high])
Attachments
(1 file)
Previously, the button in the notification simply changed from pause to play when pausing media playback, but now I also get some animation looking as if the notification disappears and is then immediately replaced by a new notification.
Resuming playback still works normally, i.e. the play/pause button simply changes its state without any further animations of the whole notification.
Flags: needinfo?(vlad.baicu)
Assignee | ||
Comment 1•6 years ago
|
||
Currently on PTO, NI-ing Andrew to take a look at this
Flags: needinfo?(vlad.baicu) → needinfo?(andrei.a.lazar)
Updated•6 years ago
|
Keywords: regressionwindow-wanted
Comment 2•6 years ago
|
||
Andrei, could you have a look please? thanks
Comment 3•6 years ago
|
||
Regression window range:
Last good build: 07-16
First bad build: 07-17
Pushlog: https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=2d4bb9aa2e342902f53ce80ac155e97cffde34bc&tochange=65677fe92b47b6a48984c204899803283f1c44e6
Keywords: regressionwindow-wanted
Updated•6 years ago
|
Assignee: nobody → andrei.a.lazar
Flags: needinfo?(andrei.a.lazar)
Reporter | ||
Comment 5•6 years ago
|
||
What's slightly worse is that according to bug 1484679, if the media control notification is the only notification showing, then this behaviour causes the notification shade to close.
Assignee | ||
Updated•6 years ago
|
Assignee: andrei.a.lazar → vlad.baicu
Assignee | ||
Comment 6•6 years ago
|
||
Instead of stopping the foreground service whenever ACTION_PAUSE was triggered,
I created a new event where we notify the service to clear its foreground state.
Cleared usages of the NotificationManager and the onGoing attribute of the
MediaNotification because they are redundant. As of Android 4.3 a service in the
foreground state will always force the notification to be persistent and callling
stopForeground(false) will clear the onGoing flag while maintaining the notification.
Comment 7•6 years ago
|
||
Comment on attachment 9004929 [details]
Bug 1479314 - Prevent media control notification flashing. r=sdaswani
Jim Chen [:jchen] [:darchons] has approved the revision.
Attachment #9004929 -
Flags: review+
Assignee | ||
Updated•6 years ago
|
Keywords: checkin-needed
Pushed by ccoroiu@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0851a63dc3bb
Prevent media control notification flashing. r=jchen
Keywords: checkin-needed
Comment 9•6 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 63
Updated•6 years ago
|
status-firefox61:
--- → unaffected
status-firefox62:
--- → unaffected
Comment 10•6 years ago
|
||
Verified as fixed on the latest version of Nightly 63.0a1 (2018-09-03).
Devices: Nokia 6 (Android 7.1.1) and OnePlus 5T (Android 8.1.0).
Status: RESOLVED → VERIFIED
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•