Sören Hentzschel Reporter
	Description • 6 years ago

Favicons are no longer shown with responsive design mode enabled and that's very annoying while developing websites. ;-)

STR:

1. open responsive design mode
2. open a website

Expected:

Favicon in tab

Actual:

Favicon is missing

I set the regressionwindow-wanted keyword because I am not sure about the regression bug. The tool mozregression shows 1472268 as first nightly without the correct favicon (but the patch from this bug has been backed out) and then there were the Nightly logo as favicon in responsive design mode for a few builds and since a few builds after this change there is no favicon at all in responsive design mode.

	Marco Bonardo [:mak]
	Comment 1 • 6 years ago

Could be related to recent work moving the favicon load to the content process

	Pascal Chevrel:pascalc (PTO until August 21)
	Comment 2 • 6 years ago

Sören, do you still have this bug in the latest nightly? Thanks

	Sören Hentzschel Reporter
	Comment 3 • 6 years ago

Yes, the favicon is still missing in the responsive design mode.

	Pascal Chevrel:pascalc (PTO until August 21)
	Comment 4 • 6 years ago

Thanks Sören, marking as blocking bug 1453751 per Marco's comment. Tracking too as this is a feature planned for 63.

	Dave Townsend [:mossop] Assignee
	Comment 5 • 6 years ago

Definitely caused by bug 1453751 but right now I can't figure out how this used to work!

	Dave Townsend [:mossop] Assignee
	Comment 6 • 6 years ago

Prior to bug 1453751 responsive design mode relied on the parent process seeing
that no favicon had been loaded and so defaulting to the root favicon for a
site. This would have meant that on some occasions responsive design mode didn't
show the correct favicon for pages that specified their own. This change passes
all the link related messages to the parent so favicons, feeds and searches
should work correctly.

	J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)
	Comment 7 • 6 years ago

Comment on attachment 8998633 [details]
Bug 1479316: Pass through link related messages when in responsive design mode. r=jryans

J. Ryan Stinnett [:jryans] has approved the revision.

	Pulsebot
	Comment 8 • 6 years ago

Pushed by dtownsend@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e367443dd417
Pass through link related messages when in responsive design mode. r=jryans

	Pulsebot
	Comment 9 • 6 years ago

Backout by dvarga@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/35b70105cbe3
Backed out changeset e367443dd417 fpor failure at devtools/client/responsive.html/test/browser/browser_favicon.js

	Andreea Pavel [:apavel]
	Comment 10 • 6 years ago

Backed out for devtools failures at devtools/client/responsive.html/test/browser/browser_favicon.js

Push that started the failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=e367443dd417aed7d28eb6eed8288c6361a50d6f

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=192879778&repo=autoland&lineNumber=5153

Backout: https://hg.mozilla.org/integration/autoland/rev/35b70105cbe3962f28c0417d1d46ac400bb95dff

	Dave Townsend [:mossop] Assignee
	Comment 11 • 6 years ago

Prior to bug 1453751 responsive design mode relied on the parent process seeing
that no favicon had been loaded and so defaulting to the root favicon for a
site. This would have meant that on some occasions responsive design mode didn't
show the correct favicon for pages that specified their own. This change passes
all the link related messages to the parent so favicons, feeds and searches
should work correctly.

	Kris Maglione [:kmag]
	Comment 12 • 6 years ago

Prior to bug 1453751 responsive design mode relied on the parent process seeing
that no favicon had been loaded and so defaulting to the root favicon for a
site. This would have meant that on some occasions responsive design mode didn't
show the correct favicon for pages that specified their own. This change passes
all the link related messages to the parent so favicons, feeds and searches
should work correctly.

	J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)
	Comment 13 • 6 years ago

Comment on attachment 8998921 [details]
Bug 1479316: Pass through link related messages when in responsive design mode. r=kmag

J. Ryan Stinnett [:jryans] has approved the revision.

	Kris Maglione [:kmag]
	Comment 14 • 6 years ago

Prior to bug 1453751 responsive design mode relied on the parent process seeing
that no favicon had been loaded and so defaulting to the root favicon for a
site. This would have meant that on some occasions responsive design mode didn't
show the correct favicon for pages that specified their own. This change passes
all the link related messages to the parent so favicons, feeds and searches
should work correctly.

	Pulsebot
	Comment 15 • 6 years ago

Pushed by dtownsend@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8fca282c5ffd
Pass through link related messages when in responsive design mode. r=jryans

	Daniel Varga [:dvarga]
	Comment 16 • 6 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/8fca282c5ffd

	Sören Hentzschel Reporter
	Comment 17 • 6 years ago

Thanks for fixing. I can verify that it works now.