Closed
Bug 1479320
Opened 6 years ago
Closed 5 years ago
Lazily load calendar unifinder tree
Categories
(Calendar :: Calendar Frontend, enhancement)
Calendar
Calendar Frontend
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 69.0
People
(Reporter: darktrojan, Assigned: darktrojan)
References
(Blocks 1 open bug)
Details
(Keywords: perf)
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
darktrojan
:
review+
|
Details | Diff | Splinter Review |
Follow up from bug 1477958 comment 6.
|
Assignee | |
Updated•6 years ago
|
Summary: Lazily load calendar unifinder tree → Lazily load calendar tasks view and unifinder tree
|
|
Assignee | |
Updated•5 years ago
|
Summary: Lazily load calendar tasks view and unifinder tree → Lazily load calendar unifinder tree
|
|
Assignee | |
Comment 1•5 years ago
|
||
Does the job.
|
||
Comment 2•5 years ago
|
||
Comment on attachment 9071175 [details] [diff] [review] 1479320-lazy-unifinder-1.diff Review of attachment 9071175 [details] [diff] [review]: ----------------------------------------------------------------- ::: calendar/base/content/calendar-unifinder.js @@ +218,5 @@ > + sortDirection = "ascending"; > + } > + let tree = document.getElementById("unifinder-search-results-tree"); > + let treecols = tree.getElementsByTagName("treecol"); > + for (let i = 0; i < treecols.length; i++) { Can you change this to a for..of while we are here?
Attachment #9071175 -
Flags: review?(philipp) → review+
|
|
Assignee | |
Comment 3•5 years ago
|
||
Attachment #9071175 -
Attachment is obsolete: true
Attachment #9071208 -
Flags: review+
|
|
Assignee | |
Comment 4•5 years ago
|
||
I think this can live on just Daily for now, then join a later beta if it all works fine and actually helps start-up performance.
Keywords: checkin-needed
|
||
Updated•5 years ago
|
Target Milestone: --- → 7.1
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/4e10b0b8aa3f
Lazily load calendar unifinder tree. r=philipp
|
|
Assignee | |
Updated•5 years ago
|
Blocks: tb-startupperf
|
||
Comment 6•5 years ago
|
||
(In reply to Geoff Lankow (:darktrojan) from comment #4)
[if] actually helps start-up performance.
Were you able to measure improvement?
Flags: needinfo?(geoff)
|
|
Assignee | |
Comment 7•5 years ago
|
||
There's many reasons we call this function, so it's difficult to say it's better in all cases. But in an extreme case, such as importing many events into a calendar which already has a lot, there's a significant improvement.
Flags: needinfo?(geoff)
You need to log in
before you can comment on or make changes to this bug.
Description
•