Closed Bug 1479385 Opened 6 years ago Closed 6 years ago

Disable stack instrumentation in Windows ASan Nightly Reporter builds

Categories

(Firefox Build System :: General, enhancement)

x86_64
Windows
enhancement
Not set
blocker

Tracking

(firefox63 fixed)

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: decoder, Assigned: decoder)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

In bug 1477490, we might have discovered a generic problem with Windows Threads and ASan. This problem causes all sorts of stack reports coming in via the ASan Nightly Project, but most of these reports are (probably) not legit. As this also affects the stability of the browser I would like to disable the stack instrumentation on Windows (only for ASan reporter builds), so we can unblock the project. We should still try to solve the underlying problem but the project's purpose is to find use-after-free and that ability will remain unaffected by this change.
I support this. Time permitting, I'd really like to understand and address the root cause here, but as a practical matter it doesn't make sense to let this hold up the usability of ASan Reporter builds.
Comment on attachment 8995938 [details] Bug 1479385 - Disable stack instrumentation for Windows Nightly ASan builds. https://reviewboard.mozilla.org/r/260240/#review267254
Attachment #8995938 - Flags: review?(dmajor) → review+
Pushed by choller@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/08c8ed833c3a Disable stack instrumentation for Windows Nightly ASan builds. r=dmajor
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: