Closed
Bug 1479411
Opened 6 years ago
Closed 6 years ago
[remote-dbg-next] Temporarily remove actions and reducers
Categories
(DevTools :: about:debugging, enhancement)
DevTools
about:debugging
Tracking
(firefox63 fixed)
RESOLVED
FIXED
Firefox 63
Tracking | Status | |
---|---|---|
firefox63 | --- | fixed |
People
(Reporter: jdescottes, Assigned: jdescottes)
References
Details
Attachments
(4 files)
As discussed in today's meeting, we would like to simplify the current code as much as possible and move carefully as we add other actions.
Also the very first action we should add is probably the possibility to switch between the Connect page and the This-Firefox page, as it will allow use to split the work.
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment 5•6 years ago
|
||
mozreview-review |
Comment on attachment 8995944 [details]
Bug 1479411 - Rename RuntimesPane to Sidebar;
https://reviewboard.mozilla.org/r/260244/#review267258
Attachment #8995944 -
Flags: review?(dakatsuka) → review+
Comment 6•6 years ago
|
||
mozreview-review |
Comment on attachment 8995945 [details]
Bug 1479411 - Rename RuntimeItem to SidebarItem;
https://reviewboard.mozilla.org/r/260246/#review267260
Attachment #8995945 -
Flags: review?(dakatsuka) → review+
Comment 7•6 years ago
|
||
mozreview-review |
Comment on attachment 8995946 [details]
Bug 1479411 - Move SidebarItem CSS variables to SidebarItem.css;
https://reviewboard.mozilla.org/r/260248/#review267262
Attachment #8995946 -
Flags: review?(dakatsuka) → review+
Comment 8•6 years ago
|
||
mozreview-review |
Comment on attachment 8995947 [details]
Bug 1479411 - Remove all actions and reducers from new about:debugging UI;
https://reviewboard.mozilla.org/r/260250/#review267264
Attachment #8995947 -
Flags: review?(dakatsuka) → review+
Assignee | ||
Updated•6 years ago
|
Assignee: nobody → jdescottes
Status: NEW → ASSIGNED
Comment 9•6 years ago
|
||
mozreview-review |
Comment on attachment 8995946 [details]
Bug 1479411 - Move SidebarItem CSS variables to SidebarItem.css;
https://reviewboard.mozilla.org/r/260248/#review267268
Thanks! I made a minor comment about where to assign the CSS variables.
::: devtools/client/aboutdebugging-new/src/components/SidebarItem.css:5
(Diff revision 1)
> /* This Source Code Form is subject to the terms of the Mozilla Public
> * License, v. 2.0. If a copy of the MPL was not distributed with this
> * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
>
> +:root {
Since these aren't treated like global colors anymore, maybe it doesn't make sense to put them under `:root`. How about moving the color declarations to the component itself? Ex:
```
.sidebar-item {
--sidebar-item-icon-color: var(--grey-30);
/* ... */
}
```
Attachment #8995946 -
Flags: review?(balbeza) → review+
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Assignee | ||
Comment 12•6 years ago
|
||
Thank you both for the reviews! I know it's painful to remove code so I'm glad this was done quickly.
Comment 13•6 years ago
|
||
Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/092a7bbeb69b
Rename RuntimesPane to Sidebar;r=daisuke
https://hg.mozilla.org/integration/autoland/rev/33a5b1e66919
Rename RuntimeItem to SidebarItem;r=daisuke
https://hg.mozilla.org/integration/autoland/rev/22dd2b91ec0d
Move SidebarItem CSS variables to SidebarItem.css;r=daisuke,ladybenko
https://hg.mozilla.org/integration/autoland/rev/2c9c2ae0f692
Remove all actions and reducers from new about:debugging UI;r=daisuke
Comment 14•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/092a7bbeb69b
https://hg.mozilla.org/mozilla-central/rev/33a5b1e66919
https://hg.mozilla.org/mozilla-central/rev/22dd2b91ec0d
https://hg.mozilla.org/mozilla-central/rev/2c9c2ae0f692
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox63:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 63
Updated•6 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•