Closed
Bug 1479519
Opened 6 years ago
Closed 6 years ago
We seem to have no test coverage for the "clear-site-data-reload-needed" case
Categories
(Core :: DOM: Security, enhancement, P2)
Core
DOM: Security
Tracking
()
RESOLVED
FIXED
mozilla63
| Tracking | Status | |
|---|---|---|
| firefox63 | --- | fixed |
People
(Reporter: bzbarsky, Assigned: baku)
References
Details
(Whiteboard: [domsecurity-active][wptsync upstream])
Attachments
(1 file)
|
(deleted),
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
Code coverage results at https://codecov.io/gh/mozilla/gecko-dev/src/db79375c66cdd69848223e9dbff5e9d2490ec3b2/toolkit/components/clearsitedata/ClearSiteData.cpp show that BrowsingContextsReloadNeeded() is never called. as a result, the "clear-site-data-reload-needed" case is never reached in nsGlobalWindowInner::Observe per https://codecov.io/gh/mozilla/gecko-dev/src/db79375c66cdd69848223e9dbff5e9d2490ec3b2/dom/base/nsGlobalWindowInner.cpp
Looking at the code coverage for ClearSiteData::ParseHeader it looks like we just have no testing for the "executionContexts" and "*" cases?
Flags: needinfo?(amarchesini)
|
Assignee | |
Comment 1•6 years ago
|
||
Assignee: nobody → amarchesini
Flags: needinfo?(amarchesini)
Attachment #8996305 -
Flags: review?(bugs)
|
||
Updated•6 years ago
|
Status: NEW → ASSIGNED
Priority: -- → P2
Whiteboard: [domsecurity-active]
|
||
Updated•6 years ago
|
Attachment #8996305 -
Flags: review?(bugs) → review+
Pushed by amarchesini@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8ded8bf9b94c
WPT for Clear-Site-Data executionContexts, r=smaug
|
||
Comment 3•6 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox63:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/12251 for changes under testing/web-platform/tests
Whiteboard: [domsecurity-active] → [domsecurity-active][wptsync upstream]
Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.
Upstream PR merged
You need to log in
before you can comment on or make changes to this bug.
Description
•