Closed Bug 1479584 Opened 6 years ago Closed 6 years ago

All tests (except geckoview-junit) failing in TestRunnerActivity ("SpecialPowers is not defined")

Categories

(GeckoView :: General, defect)

defect
Not set
normal

Tracking

(firefox-esr52 wontfix, firefox-esr60 wontfix, firefox61 wontfix, firefox62 wontfix, firefox63 fixed)

RESOLVED FIXED
mozilla63
Tracking Status
firefox-esr52 --- wontfix
firefox-esr60 --- wontfix
firefox61 --- wontfix
firefox62 --- wontfix
firefox63 --- fixed

People

(Reporter: gbrown, Assigned: jchen)

References

Details

Attachments

(1 file)

In bug 1452694, we had mochitests and reftests mostly-working (some tests failing, but most passing) in TestRunnerActivity. Now nothing is working: All tests time out on startup. You can see that on packet.net on try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=68f47decb3fa21d6230b8035340dfd7a14f6bedb Locally, if I run ./mach mochitest testing/mochitest/tests/Harness_sanity --app=org.mozilla.geckoview.test I see TestRunnerActivity start and load the main mochitest page, but then it hangs waiting for a test to run. logcat consistently contains "SpecialPowers is not defined": 07-30 20:37:34.891 4475 4490 D GeckoViewNavigation[C]: loadURI: uri=http://mochi.test:8888/tests?autorun=1&closeWhenDone=1&logFile=%2Fsdcard%2Ftests%2Flogs%2Fmochitest.log&fileLevel=INFO&consoleLevel=INFO&hideResultsTable=1&manifestFile=tests.json&dumpOutputDirectory=%2Fsdcard%2Ftests where=1 flags=0x1 07-30 20:37:34.892 4475 4490 D GeckoViewSettings[C]: onSettingsUpdate 07-30 20:37:34.893 4475 4490 D GeckoViewContent[C]: handleEvent: DOMTitleChanged 07-30 20:37:34.900 4409 4509 I GeckoConsole: PAC file installed from data: URI 07-30 20:37:34.923 4475 4490 D GeckoViewSelectionAction[C]: handleEvent: visibilitychange 07-30 20:37:34.929 4409 4424 D GeckoViewNavigation: onLocationChange 07-30 20:37:34.948 4475 4490 D GeckoViewContent[C]: handleEvent: DOMTitleChanged 07-30 20:37:35.019 4475 4490 E Web Content: [JavaScript Error: "ReferenceError: SpecialPowers is not defined" {file: "http://mochi.test:8888/tests/SimpleTest/setup.js" line: 108}] 07-30 20:37:35.019 4475 4490 E Web Content: @http://mochi.test:8888/tests/SimpleTest/setup.js:108:3 07-30 20:37:35.023 4475 4490 D GeckoViewContent[C]: handleEvent: DOMTitleChanged 07-30 20:37:35.043 4475 4490 I GeckoDump: TEST-UNEXPECTED-FAIL: manifestLibrary.js | error parsing http://mochi.test:8888/tests.json (TypeError: RunSet is undefined) 07-30 20:37:35.043 4475 4490 E Web Content: [JavaScript Error: "TypeError: RunSet is undefined" {file: "http://mochi.test:8888/tests/SimpleTest/setup.js" line: 262}] 07-30 20:37:35.043 4475 4490 E Web Content: hookupTests@http://mochi.test:8888/tests/SimpleTest/setup.js:262:3 07-30 20:37:35.043 4475 4490 E Web Content: parseTestManifest@http://mochi.test:8888/manifestLibrary.js:36:5 07-30 20:37:35.043 4475 4490 E Web Content: getTestManifest/req.onload@http://mochi.test:8888/manifestLibrary.js:49:11 07-30 20:38:34.615 4409 4424 E GeckoConsole: [JavaScript Error: "Polling for changes failed: Server error 404 Not Found: "JSON.parse: unexpected character at line 1 column 1 of the JSON data"." {file: "resource://services-settings/remote-settings.js" line: 717}] This very much reminds me of https://bugzilla.mozilla.org/show_bug.cgi?id=1426822#c30, where I saw the same symptoms intermittently in Fennec tests...but those were addressed by the backout of bug 1451513, which hasn't been re-landed.
(In reply to Geoff Brown [:gbrown] from comment #0) SpecialPowers is not defined because... 07-30 19:51:01.750 2341 2356 I Gecko : 1532976661750 addons.xpi WARN List of valid built-in add-ons could not be parsed.: [Exception... "Component returned failure code: 0x80520012 (NS_ERROR_FILE_NOT_FOUND) [nsIXPCComponents_Utils.readUTF8URI]" nsresult: "0x80520012 (NS_ERROR_FILE_NOT_FOUND)" location: "JS frame :: resource://gre/modules/addons/XPIProvider.jsm :: startup :: line 2093" data: no] Stack trace: startup()@resource://gre/modules/addons/XPIProvider.jsm:2093 07-30 19:51:01.750 2341 2356 I Gecko : callProvider()@resource://gre/modules/AddonManager.jsm:206 07-30 19:51:01.750 2341 2356 I Gecko : _startProvider()@resource://gre/modules/AddonManager.jsm:654 07-30 19:51:01.750 2341 2356 I Gecko : startup()@resource://gre/modules/AddonManager.jsm:813 07-30 19:51:01.750 2341 2356 I Gecko : startup()@resource://gre/modules/AddonManager.jsm:2812 07-30 19:51:01.750 2341 2356 I Gecko : observe()@jar:jar:file:///data/app/org.mozilla.geckoview.test-1/base.apk!/assets/omni.ja!/components/addonManager.js:66 07-30 19:51:01.760 2341 2356 I Gecko : 1532976661760 addons.xpi WARN No list of valid system add-ons found. 07-30 19:51:01.770 2341 2341 D GeckoNetworkManager: Incoming event enableNotifications for state OffNoListeners -> OffWithListeners 07-30 19:51:01.780 2341 2341 D GeckoNetworkManager: New network state: UP, CELLULAR, CELL_4G 07-30 19:51:01.840 2341 2356 I GeckoConsole: No chrome package registered for chrome://browser/content/ext-android.js 07-30 19:51:01.840 2341 2356 I GeckoConsole: No chrome package registered for chrome://browser/content/ext-utils.js 07-30 19:51:01.840 2341 2356 I GeckoConsole: 1532976661840 addons.xpi-utils WARN addMetadata: Add-on special-powers@mozilla.org is invalid: [Exception... "File error: Not found" nsresult: "0x80520012 (NS_ERROR_FILE_NOT_FOUND)" location: "JS frame :: resource://gre/modules/ExtensionParent.jsm :: lazyInit/scripts< :: line 133" data: no] Stack trace: lazyInit/scripts<()@resource://gre/modules/ExtensionParent.jsm:133 07-30 19:51:01.840 2341 2356 I GeckoConsole: lazyInit/promise<()@resource://gre/modules/ExtensionParent.jsm:133 07-30 19:51:01.840 2341 2356 I GeckoConsole: lazyInit()@resource://gre/modules/ExtensionParent.jsm:132 07-30 19:51:01.840 2341 2356 I GeckoConsole: parseManifest()@resource://gre/modules/Extension.jsm:541 07-30 19:51:01.840 2341 2356 I GeckoConsole: loadManifest()@resource://gre/modules/Extension.jsm:809 07-30 19:51:01.840 2341 2356 I GeckoConsole: loadManifestFromWebManifest()@resource://gre/modules/addons/XPIInstall.jsm:433 07-30 19:51:01.840 2341 2356 I GeckoConsole: loadManifest()@resource://gre/modules/addons/XPIInstall.jsm:807 07-30 19:51:01.840 2341 2356 I GeckoConsole: awaitPromise()@resource://gre/modules/addons/XPIProvider.jsm:190 07-30 19:51:01.840 2341 2356 I GeckoConsole: syncLoadManifestFromFile()@resource://gre/modules/addons/XPIInstall.jsm:866 07-30 19:51:01.840 2341 2356 I GeckoConsole: addMetadata()@resource://gre/modules/addons/XPIDatabase.jsm:2389 07-30 19:51:01.840 2341 2356 I GeckoConsole: processFileChanges()@resource://gre/modules/addons/XPIDatabas
(In reply to Geoff Brown [:gbrown] from comment #0) > This very much reminds me of > https://bugzilla.mozilla.org/show_bug.cgi?id=1426822#c30, where I saw the > same symptoms intermittently in Fennec tests...but those were addressed by > the backout of bug 1451513, which hasn't been re-landed. There are new patches in bug 1451513. They work fine for Android/Fennec but do not fix this problem. https://treeherder.mozilla.org/#/jobs?repo=try&revision=7446146c740a5ca77e47a8b1ad21ab28f10543e3
I think that's the same error that :rwood is seeing. I was going to take a look at it.
(In reply to Jim Chen [:jchen] [:darchons] from comment #3) > I think that's the same error that :rwood is seeing. I was going to take a > look at it. Yes we are seeing this also (with raptor) thanks
I think "List of valid built-in add-ons could not be parsed" happens when trying to read built_in_addons.json. Fennec's omni.ja contains chrome/chrome/content/built_in_addons.json, but geckoview's does not.
Blocks: 1472298
Assignee: nobody → nchen
Status: NEW → ASSIGNED
Comment on attachment 8996807 [details] Bug 1479584 - Move WebExtension modules to GeckoView; https://reviewboard.mozilla.org/r/260862/#review267880 r=me assuming this doesn't break anything in Fennec.
Attachment #8996807 - Flags: review?(kmaglione+bmo) → review+
(In reply to Geoff Brown [:gbrown] from comment #5) > I think "List of valid built-in add-ons could not be parsed" happens when > trying to read built_in_addons.json. It does, but it's a red herring, in this case. We should probably do something to prevent this warning in GeckoView, but none of the test frameworks rely on system add-ons, and that error is non-fatal.
Jim's patch pushed to try with a sampling of Android 4.3 tests + the new Android 7.0 geckoview tests on packet.net: https://treeherder.mozilla.org/#/jobs?repo=try&revision=fadbecce6fc8be164f5a53883ecf3d779704e5fa - resolves this bug on packet.net tests - no new problems on Android 4.3 Awesome! Thanks :jchen! Thanks :kmag!
Pushed by nchen@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/baf5ca8b7812 Move WebExtension modules to GeckoView; r=kmag
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 63
status-firefox62=wontfix because we don't need to uplift this test fix.
Product: Firefox for Android → GeckoView
Target Milestone: Firefox 63 → mozilla63
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: