Closed
Bug 1479708
Opened 6 years ago
Closed 5 years ago
Required date input still has a clear button
Categories
(Toolkit :: XUL Widgets, defect, P3)
Tracking
()
RESOLVED
FIXED
mozilla70
| Tracking | Status | |
|---|---|---|
| firefox70 | --- | fixed |
People
(Reporter: mcorteel, Assigned: bugzilla)
References
(Blocks 1 open bug, )
Details
(Keywords: parity-chrome, testcase)
Attachments
(2 files, 1 obsolete file)
User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:61.0) Gecko/20100101 Firefox/61.0
Build ID: 20180704194937
Steps to reproduce:
Create a form with a required date input and set its value. (See https://codepen.io/anon/pen/VBQeQW)
Actual results:
The input contains a clear button.
Expected results:
It shouldn't, because if you clear the input, the validation will always fail.
I'm not completely sure if it's a bug or a feature, but it doesn't make much sense.
|
||
Updated•6 years ago
|
Blocks: datetime-bugs
Has STR: --- → yes
Component: Untriaged → Layout: Form Controls
Keywords: parity-chrome,
testcase
OS: Unspecified → All
Product: Firefox → Core
Hardware: Unspecified → All
|
||
Updated•6 years ago
|
Priority: -- → P3
|
||
Comment 1•6 years ago
|
||
(In reply to Maxime Corteel from comment #0)
> It shouldn't, because if you clear the input, the validation will always
> fail.
> I'm not completely sure if it's a bug or a feature, but it doesn't make much
> sense.
I believe this is a bug. Chrome correctly hides the clear button when the required attribute is set.
|
|
||
Updated•6 years ago
|
Status: UNCONFIRMED → NEW
Ever confirmed: true
|
|
||
Comment 2•6 years ago
|
||
Putting this in Toolkit > XUL Widgets since it appears the current datetimebox widget does not appear to respect the required attribute.
The method updateResetButtonVisibility in datetimebox.xml looks to see if any field is non-empty in the widget, and if it is, sets the mResetButton visibility to visible.
See https://searchfox.org/mozilla-central/source/toolkit/content/widgets/datetimebox.xml#1373
Component: Layout: Form Controls → XUL Widgets
Product: Core → Toolkit
|
Assignee | |
Comment 3•5 years ago
|
||
|
|
Assignee | |
Comment 4•5 years ago
|
||
|
||
Updated•5 years ago
|
Attachment #9079042 -
Attachment is obsolete: true
|
||
Updated•5 years ago
|
Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a506f9517ba2
Hide required date time input reset button. r=emilio
|
||
Comment 7•5 years ago
|
||
Backed out for failing test_input_datetime_reset_button.html
Push with failures https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedJob=258262109&resultStatus=testfailed%2Cbusted%2Cexception&revision=a506f9517ba274ad95efdb8b5dfc4239d1a72684
Failure log https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=258262109&repo=autoland&lineNumber=5665
Backout: https://hg.mozilla.org/integration/autoland/rev/62164e4678c0d4f2f728760da00d5386bc2d3b58
Flags: needinfo?(bugzilla)
|
|
Assignee | |
Comment 8•5 years ago
|
||
|
|
Assignee | |
Comment 9•5 years ago
|
||
Sorry the change had to be backed out. The test failure wasn’t caught earlier because the try server run did not test the mobile version.
Flags: needinfo?(bugzilla)
|
||
Comment 10•5 years ago
|
||
Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3d066652bc2f
Hide required date time input reset button. r=emilio
|
||
Comment 11•5 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox70:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla70
|
||
Updated•5 years ago
|
Assignee: nobody → bugzilla
|
||
Updated•5 years ago
|
QA Whiteboard: [qa-70b-p2]
You need to log in
before you can comment on or make changes to this bug.
Description
•