Closed
Bug 1479961
Opened 6 years ago
Closed 6 years ago
JSNatives have no callers in the hazard analysis callgraph
Categories
(Core :: JavaScript: GC, enhancement, P3)
Core
JavaScript: GC
Tracking
()
RESOLVED
FIXED
mozilla65
Tracking | Status | |
---|---|---|
firefox65 | --- | fixed |
People
(Reporter: sfink, Assigned: sfink)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
(deleted),
patch
|
jonco
:
review+
|
Details | Diff | Splinter Review |
It doesn't actually matter for the hazard analysis itself, since RunScript and friends can already GC and having the JSNative in the graph doesn't help.
But it's kind of useful for other callgraph uses.
Assignee | ||
Comment 1•6 years ago
|
||
Attachment #8996508 -
Flags: review?(jcoppeard)
Comment 2•6 years ago
|
||
Comment on attachment 8996508 [details] [diff] [review]
Synthesize call edges from Interpret and EnterJit to all JSNatives
Review of attachment 8996508 [details] [diff] [review]:
-----------------------------------------------------------------
Yes, makes sense.
::: js/src/devtools/rootAnalysis/computeCallgraph.js
@@ +289,5 @@
> + JSNatives.push(functionName);
> +}
> +
> +function postprocess_callgraph() {
> + for (const caller of Object.keys(JSNativeCaller)) {
Could use a comment to say what this is doing.
Attachment #8996508 -
Flags: review?(jcoppeard) → review+
Assignee | ||
Updated•6 years ago
|
Priority: -- → P3
Pushed by sfink@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c22b643cdf51
Synthesize call edges from Interpret and EnterJit to all JSNatives, r=jonco
Backout by sfink@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/06ffaf98e1e9
Backed out changeset c22b643cdf51 (bug 1479961, bug 1480129)
Pushed by sfink@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/113e7326a16a
Synthesize call edges from Interpret and EnterJit to all JSNatives, r=jonco
Comment 6•6 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox65:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
You need to log in
before you can comment on or make changes to this bug.
Description
•