Closed
Bug 1479962
Opened 6 years ago
Closed 6 years ago
Switch to using attributes instead of coded annotations for AutoGCRooter & friends
Categories
(Core :: JavaScript: GC, enhancement)
Core
JavaScript: GC
Tracking
()
RESOLVED
FIXED
mozilla63
| Tracking | Status | |
|---|---|---|
| firefox63 | --- | fixed |
People
(Reporter: sfink, Assigned: sfink)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
(deleted),
patch
|
jonco
:
review+
|
Details | Diff | Splinter Review |
RootedWhatever's rootedness is not inherited by subclasses or containing structures, so I can't use the same mechanism for AutoGCRooter. But I dislike hardcoded non-attribute exceptions in the JS analysis code.
|
Assignee | |
Comment 1•6 years ago
|
||
Attachment #8996509 -
Flags: review?(jcoppeard)
|
||
Updated•6 years ago
|
Attachment #8996509 -
Flags: review?(jcoppeard) → review+
Pushed by sfink@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5b595406855e
Add JS_HAZ_ROOTED_BASE for AutoGCRooter, which assumes all descendants are rooted, r=jonco
|
||
Comment 3•6 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox63:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in
before you can comment on or make changes to this bug.
Description
•