Closed Bug 1479963 Opened 6 years ago Closed 6 years ago

Missing callgraph edges due to unhandled constructs

Categories

(Core :: JavaScript: GC, enhancement, P2)

Product:
Core
Component:
JavaScript: GC
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: sfink, Assigned: sfink)

References

(Blocks 1 open bug)

Details

Attachments

(3 files)

Make sixgill ignore some unhandled constructs
(deleted), patch
Details | Diff | Splinter Review
Ignore some unhandled stuff
(deleted), patch
bhackett1024
: review+
Details | Diff | Splinter Review
"Handle" unary plus, and stop bailing on non-destructors
(deleted), patch
bhackett1024
: review+
Details | Diff | Splinter Review
sixgill was choking on a few more things and discarding CFGs.
Attached patch Ignore some unhandled stuff (deleted) — — Splinter Review
I ran into both of these things at important places (triggering a false positive hazard because it couldn't follow GC suppression through the callgraph).
Attachment #8996513 - Flags: review?(bhackett1024)
IL_IsDestructor was returning true for things like std::forward<Foo::~Foo::<lambda()>> because it saw a "::~" substring in something that isn't even a method, let alone a destructor.
Attachment #8996514 - Flags: review?(bhackett1024)
Attachment #8996513 - Flags: review?(bhackett1024) → review+
Attachment #8996514 - Flags: review?(bhackett1024) → review+
Priority: -- → P2
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: