Closed
Bug 1480055
Opened 6 years ago
Closed 6 years ago
Sort out around nsIEditor::ShouldTxnSetSelection()
Categories
(Core :: DOM: Editor, enhancement)
Core
DOM: Editor
Tracking
()
RESOLVED
FIXED
mozilla63
| Tracking | Status | |
|---|---|---|
| firefox63 | --- | fixed |
People
(Reporter: masayuki, Assigned: masayuki)
References
(Blocks 1 open bug)
Details
Attachments
(4 files)
No description provided.
|
Assignee | |
Comment 1•6 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=09c3fed741fa1ebe158afaaf851a9c12bedf3ec6
|
|
Assignee | |
Comment 2•6 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=70e8918e3e5a931571a52a3337003a25fd35b962
|
|
Assignee | |
Comment 3•6 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=7f65f6681bde58003cee64715377a5a634544b60
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
|
||
Comment 8•6 years ago
|
||
| mozreview-review | ||
Comment on attachment 8996935 [details] Bug 1480055 - part 1: Remove nsIEditor::shouldTxnSetSelection() https://reviewboard.mozilla.org/r/260924/#review268160
Attachment #8996935 -
Flags: review?(m_kato) → review+
|
|
||
Comment 9•6 years ago
|
||
| mozreview-review | ||
Comment on attachment 8996936 [details] Bug 1480055 - part 2: Rename EditorBase::GetShouldTxnSetSelection() to EditorBase::AllowsTransactionsToChangeSelection() https://reviewboard.mozilla.org/r/260926/#review268164
Attachment #8996936 -
Flags: review?(m_kato) → review+
|
|
||
Comment 10•6 years ago
|
||
| mozreview-review | ||
Comment on attachment 8996937 [details] Bug 1480055 - part 3: Create non-virtual method to set EditorBase::mAllowsTransactionsToChangeSelection https://reviewboard.mozilla.org/r/260928/#review268178
Attachment #8996937 -
Flags: review?(m_kato) → review+
|
|
||
Comment 11•6 years ago
|
||
| mozreview-review | ||
Comment on attachment 8996938 [details] Bug 1480055 - part 4: Make AutoTransactionsConserveSelection take reference of Editor rather than pointer https://reviewboard.mozilla.org/r/260930/#review268198
Attachment #8996938 -
Flags: review?(m_kato) → review+
|
||
Comment 12•6 years ago
|
||
Pushed by masayuki@d-toybox.com: https://hg.mozilla.org/integration/autoland/rev/6b0f8b1b33c0 part 1: Remove nsIEditor::shouldTxnSetSelection() r=m_kato https://hg.mozilla.org/integration/autoland/rev/a3ee99eced65 part 2: Rename EditorBase::GetShouldTxnSetSelection() to EditorBase::AllowsTransactionsToChangeSelection() r=m_kato https://hg.mozilla.org/integration/autoland/rev/702671b11b7c part 3: Create non-virtual method to set EditorBase::mAllowsTransactionsToChangeSelection r=m_kato https://hg.mozilla.org/integration/autoland/rev/e0fa16503d34 part 4: Make AutoTransactionsConserveSelection take reference of Editor rather than pointer r=m_kato
|
||
Comment 13•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/6b0f8b1b33c0 https://hg.mozilla.org/mozilla-central/rev/a3ee99eced65 https://hg.mozilla.org/mozilla-central/rev/702671b11b7c https://hg.mozilla.org/mozilla-central/rev/e0fa16503d34
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
|
|
Assignee | |
Updated•4 years ago
|
Blocks: redesign-editor-scriptable-API
You need to log in
before you can comment on or make changes to this bug.
Description
•