Henrik Skupin [:whimboo][⌚️UTC+2] Reporter
	Description • 6 years ago

The following code in Marionette needs to be updated to make use of the new `WebDriver:AcceptAlert` end-point:

https://searchfox.org/mozilla-central/rev/196560b95f191b48ff7cba7c2ba9237bba6b5b6a/testing/marionette/client/marionette_driver/marionette.py#546

	Henrik Skupin [:whimboo][⌚️UTC+2] Reporter
	Comment 3 • 6 years ago

Vinícius, thank you a lot for this patch! I triggered a try build to verify that it all works. Once it has been completed I will review your patch.

	Henrik Skupin [:whimboo][⌚️UTC+2] Reporter
	Comment 4 • 6 years ago
mozreview-review

Comment on attachment 8996860 [details]
Bug 1480105 - Using WebDriver:AcceptAlert instead of WebDriver:AcceptDialog in Marionette.

https://reviewboard.mozilla.org/r/260874/#review267972

Looks good!

	Pulsebot
	Comment 5 • 6 years ago

Pushed by hskupin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/da105ff7490c
Using WebDriver:AcceptAlert instead of WebDriver:AcceptDialog in Marionette. r=whimboo

	Cosmin Sabou [:CosminS]
	Comment 6 • 6 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/da105ff7490c

	u602518 Assignee
	Comment 7 • 6 years ago

Henrik, that's great! I'm looking to get involved with the Auto-Tools teams, so I will be looking into other good bugs to get a better grasp of the code base and workflow.

	Henrik Skupin [:whimboo][⌚️UTC+2] Reporter
	Comment 8 • 6 years ago

Wonderful. Please don't miss to join us on IRC. You can find me as whimboo in the #ateam channel. Best if you get in contact with me and we can find something else for you. Thanks.