Closed
Bug 1480448
Opened 6 years ago
Closed 6 years ago
FastBlock should honor the browser.contentblocking.enabled pref
Categories
(Core :: Networking: HTTP, defect, P1)
Core
Networking: HTTP
Tracking
()
VERIFIED
FIXED
mozilla63
| Tracking | Status | |
|---|---|---|
| firefox63 | --- | verified |
People
(Reporter: johannh, Assigned: francois)
References
Details
(Whiteboard: [necko-triaged])
Attachments
(1 file)
browser.contentblocking.enabled (introduced in bug 1476217) is the central preference that users can use to turn off all types of content blocking: Tracking Protection, FastBlock, Third Party storage restrictions, etc.
This means FastBlock code should honor it and not block when the pref is set to false.
|
Reporter | |
Updated•6 years ago
|
|
|
Reporter | |
Comment 1•6 years ago
|
||
Depending on how this is implemented we might be able to solve this in bug 1480450, it's probably still a good idea to keep this bug around for posterity.
|
||
Updated•6 years ago
|
Priority: -- → P2
Whiteboard: [necko-triaged]
|
Assignee | |
Comment 2•6 years ago
|
||
I can take this since I'm already doing the same for tracking protection in bug 1480450.
Assignee: nobody → francois
Status: NEW → ASSIGNED
Priority: P2 → P1
|
|
Assignee | |
Comment 3•6 years ago
|
||
|
||
Comment 4•6 years ago
|
||
Comment on attachment 8999303 [details]
Bug 1480448 - Honor browser.contentblocking.enabled in Fastblock. r=xeonchen!
Gary Chen [:xeonchen] use needinfo? please has approved the revision.
Attachment #8999303 -
Flags: review+
Pushed by fmarier@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b225b5030a16
Honor browser.contentblocking.enabled in Fastblock. r=xeonchen!
|
||
Comment 6•6 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox63:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
|
||
Updated•6 years ago
|
Flags: qe-verify+
|
|
||
Comment 7•6 years ago
|
||
I can confirm this issue is fixed, I verified using Fx 63.0b11, on Windows 10 x 64, macOS 10.13.6 and Ubuntu 14.04 LTS.
You need to log in
before you can comment on or make changes to this bug.
Description
•