Open
Bug 1480477
Opened 6 years ago
Updated 2 years ago
Removing DOM children where positional pseudo-classes are involved is really slow.
Categories
(Core :: CSS Parsing and Computation, defect, P2)
Core
CSS Parsing and Computation
Tracking
()
NEW
| Performance Impact | medium |
People
(Reporter: emilio, Unassigned, NeedInfo)
References
(Depends on 1 open bug, Blocks 3 open bugs)
Details
(Keywords: perf:responsiveness, Whiteboard: [layout:backlog:quality])
Attachments
(1 file)
|
(deleted),
text/html
|
Details |
See the test-case. Change firstChild by lastChild to make it twice as fast.
That being said, we're still pretty slow even with that... Need to look at what other engines are doing.
See bugs related to bug 1443066 for another more fine-grained invalidation that would make this cheaper, maybe.
|
Reporter | |
Updated•6 years ago
|
Flags: needinfo?(emilio)
|
|
Reporter | |
Comment 1•6 years ago
|
||
Repurposing because we're really slow even with that fixed... :(
Summary: Expansion of LaterSiblings hints can make removal of children O(n^2) → Removing DOM children where positional pseudo-classes are involved is really slow.
|
||
Comment 2•6 years ago
|
||
[setting this to p1 since it seems important & to get it out of triage queue -- feel free to adjust if you think that's higher priority than is merited though.]
Priority: -- → P1
|
||
Updated•6 years ago
|
Whiteboard: [qf]
|
||
Updated•6 years ago
|
Whiteboard: [qf] → [qf:p1:f67]
|
||
Updated•6 years ago
|
Whiteboard: [qf:p1:f67] → [qf:p1:f67][layout:p1]
|
|
||
Comment 4•6 years ago
|
||
--> categorizing as "responsiveness", given that this was from a dynamic-adding/removing-elements part of a benchmark (bug 1443066). And bumping to qf:p2 since qf:p1 is now reserved for pageload.
Whiteboard: [qf:p1:f67][layout:p1] → [qf:p2:responsiveness][layout:p1]
|
|
Reporter | |
Updated•6 years ago
|
|
|
Reporter | |
Updated•6 years ago
|
Flags: needinfo?(emilio)
|
|
Reporter | |
Comment 5•6 years ago
|
||
(Just putting it further up in the ni? queue, sorry for the spam)
Flags: needinfo?(emilio)
|
|
||
Updated•5 years ago
|
Priority: P1 → P2
Whiteboard: [qf:p2:responsiveness][layout:p1] → [qf:p2:responsiveness][layout:backlog:quality]
|
||
Updated•3 years ago
|
Performance Impact: --- → P2
Keywords: perf:responsiveness
Whiteboard: [qf:p2:responsiveness][layout:backlog:quality] → [layout:backlog:quality]
|
||
Updated•2 years ago
|
Severity: normal → S3
You need to log in
before you can comment on or make changes to this bug.
Description
•