Closed
Bug 1480666
Opened 6 years ago
Closed 6 years ago
Make EditorBase::EndUpdateViewBatch() non-virtual
Categories
(Core :: DOM: Editor, enhancement)
Core
DOM: Editor
Tracking
()
RESOLVED
FIXED
mozilla63
| Tracking | Status | |
|---|---|---|
| firefox63 | --- | fixed |
People
(Reporter: masayuki, Assigned: masayuki)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
HTMLEditor::EndUpdateViewBatch() calls an XPCOM method of nsIHTMLEditor, however, looks like that this can be non-virtual.
|
Assignee | |
Comment 1•6 years ago
|
||
|
|
Assignee | |
Comment 2•6 years ago
|
||
Although HTMLEditor::EndUpdateViewBatch() calls a method of nsIHTMLEditor,
the additional work after calling EditorBase::EndUpdateViewBatch() is enough
simple. So, we can move the implementation in HTMLEditor to EditorBase and
make it non-virtual.
|
||
Comment 3•6 years ago
|
||
Comment on attachment 8997355 [details]
Bug 1480666 - Make EditorBase::EndUpdateViewBatch() non-virtual
Makoto Kato [:m_kato] has approved the revision.
https://phabricator.services.mozilla.com/D2705
Attachment #8997355 -
Flags: review+
Pushed by masayuki@d-toybox.com:
https://hg.mozilla.org/integration/autoland/rev/260bf1050ee2
Make EditorBase::EndUpdateViewBatch() non-virtual r=m_kato
|
||
Comment 5•6 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in
before you can comment on or make changes to this bug.
Description
•