Closed
Bug 1480717
Opened 6 years ago
Closed 6 years ago
Credit card form billing address validation and layout
Categories
(Firefox :: WebPayments UI, defect, P1)
Firefox
WebPayments UI
Tracking
()
VERIFIED
FIXED
Firefox 64
Tracking | Status | |
---|---|---|
firefox64 | --- | verified |
People
(Reporter: tbabos, Assigned: MattN)
References
(Depends on 1 open bug, Blocks 1 open bug)
Details
(Whiteboard: [webpayments])
Attachments
(1 file)
[Affected versions]:
Nightly 63.0a1
[Affected platforms]:
Windows 10 x64, Ubuntu 16.04, Mac OS 10.13
[Prerequisites]:
- set the pref dom.payments.request.enabled to "true"
- have a profile with saved cards
[Steps to reproduce]:
1. Go to “https://rsolomakhin.github.io/pr/single/” and click on “Buy” button
2. Select a saved shipping address
3. Click on “Add” link for a new Credit Card
4. Fill all the field with valid data, except billing address – select the blank option for it
5. Click on “Add” button
6. Type in the CVV code and click on “Pay”
[Expected Result]:
The “Add” button from the Add Credit Card screen should be grayed out if the billing address is missing.
The Payment should be processed only when all the fields from Credit Card are filled.
[Actual Result]:
The payment will be processed without the billing address for the selected card.
Flags: qe-verify+
Updated•6 years ago
|
Priority: -- → P2
Whiteboard: [webpayments] [triage] → [webpayments-reserve]
Assignee | ||
Comment 1•6 years ago
|
||
Reminder to add the asterisk to the field(s) when making it required.
Updated•6 years ago
|
Whiteboard: [webpayments-reserve] → [webpayments]
Assignee | ||
Comment 2•6 years ago
|
||
I'll take this bug and also use it to make the billing address and persist checkbox position match the specs.
Assignee: nobody → MattN+bmo
Status: NEW → ASSIGNED
status-firefox63:
affected → ---
Priority: P2 → P1
Assignee | ||
Comment 3•6 years ago
|
||
Updated•6 years ago
|
Attachment #9003660 -
Attachment description: Bug 1480717 - Fix credit card form billing address and persist checkbox layout. → Bug 1480717 - Fix credit card form billing address and persist checkbox layout. r=sfoster
Assignee | ||
Comment 4•6 years ago
|
||
Assignee | ||
Comment 5•6 years ago
|
||
If there are no review issues, feel free to autoland this.
Assignee | ||
Comment 6•6 years ago
|
||
Rebased try push still looks good: https://treeherder.mozilla.org/#/jobs?repo=try&revision=1220662c34c3c80fd47ff2d256f0ae888800ae79
Comment 7•6 years ago
|
||
Comment on attachment 9003660 [details]
Bug 1480717 - Fix credit card form billing address and persist checkbox layout. r=sfoster
Sam Foster [:sfoster] has approved the revision.
Attachment #9003660 -
Flags: review+
Pushed by mozilla@noorenberghe.ca:
https://hg.mozilla.org/integration/autoland/rev/32d9dbdfae6b
Fix credit card form billing address and persist checkbox layout. r=sfoster
Assignee | ||
Updated•6 years ago
|
Summary: Credit card form can be saved without a billing address → Credit card form billing address validation and layout
Comment 9•6 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox64:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 64
Comment 10•6 years ago
|
||
Verified as fixed on Firefox Nightly 64.0a1 on Windows 10 x 64, Windows 7 x32, Mac OS X 10.13 and Ubuntu 18.04 x64.
You need to log in
before you can comment on or make changes to this bug.
Description
•