Closed
Bug 1480798
Opened 6 years ago
Closed 6 years ago
Missing RTL support for about:crashes
Categories
(Core :: Internationalization, defect)
Core
Internationalization
Tracking
()
RESOLVED
FIXED
mozilla63
Tracking | Status | |
---|---|---|
firefox-esr52 | --- | unaffected |
firefox-esr60 | --- | unaffected |
firefox61 | --- | unaffected |
firefox62 | --- | unaffected |
firefox63 | --- | fixed |
People
(Reporter: itiel_yn8, Assigned: zbraniecki)
References
Details
(Keywords: regression)
Attachments
(3 files)
This used to be okay a few days ago.
Didn't confirm it with Mozregression but I think bug 1476034 introduced this issue.
See attached.
Updated•6 years ago
|
Assignee: nobody → adeschamps
Status: NEW → ASSIGNED
Comment 1•6 years ago
|
||
Going to be switching to use https://developer.mozilla.org/en-US/docs/Archive/Themes/Making_sure_your_theme_works_with_RTL_locales instead of the now removed DTD. The implementation will be done in https://bugzilla.mozilla.org/show_bug.cgi?id=1476062.
Assignee | ||
Comment 2•6 years ago
|
||
I have a patch that sets the document's directionality in bug 1455649. I'll extract it here
I talked to Alexis on IRC and I'm taking over this bug.
Assignee: adeschamps → gandalf
Component: General → Internationalization
Product: Firefox → Core
Assignee | ||
Comment 3•6 years ago
|
||
Set document's directionality in Fluent.
Comment 4•6 years ago
|
||
Comment on attachment 8997486 [details]
Bug 1480798 - Set document's directionality in Fluent. r?stas
Staś Małolepszy :stas has approved the revision.
https://phabricator.services.mozilla.com/D2732
Attachment #8997486 -
Flags: review+
Pushed by zbraniecki@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c0bf622859f6
Set document's directionality in Fluent. r=stas
Comment 6•6 years ago
|
||
Backed out changeset c0bf622859f6 (bug 1480798) for chrome failures at intl/l10n/test/dom/test_domloc.xul
Backout: https://hg.mozilla.org/integration/autoland/rev/f20fddf6df089117e5d56fea72e97d0f33fad1a7
Failure push: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=c0bf622859f64edad0f259277758bbbe11bb3cbf&selectedJob=191945058
Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=191945058&repo=autoland&lineNumber=1840
[task 2018-08-03T20:32:50.954Z] 20:32:50 INFO - 77 INFO TEST-START | intl/l10n/test/dom/test_domloc.xul
[task 2018-08-03T20:37:48.891Z] 20:37:48 INFO - 78 INFO TEST-UNEXPECTED-FAIL | intl/l10n/test/dom/test_domloc.xul | Test timed out.
[task 2018-08-03T20:37:48.891Z] 20:37:48 INFO - reportError@chrome://mochikit/content/tests/SimpleTest/TestRunner.js:121:7
[task 2018-08-03T20:37:48.891Z] 20:37:48 INFO - TestRunner._checkForHangs@chrome://mochikit/content/tests/SimpleTest/TestRunner.js:142:7
Flags: needinfo?(gandalf)
Pushed by zbraniecki@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1748bdd2dcaf
Set document's directionality in Fluent. r=stas
Comment 9•6 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox63:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
Reporter | ||
Comment 10•6 years ago
|
||
Some elements are still LTR'd on latest Nightly.
Should I file a new bug for that?
Reporter | ||
Comment 11•6 years ago
|
||
Comment 12•6 years ago
|
||
(In reply to Itiel from comment #10)
> Some elements are still LTR'd on latest Nightly.
> Should I file a new bug for that?
Yes, please. That seems like some CSS in need of fixing.
Updated•6 years ago
|
status-firefox61:
--- → unaffected
status-firefox62:
--- → unaffected
status-firefox-esr52:
--- → unaffected
status-firefox-esr60:
--- → unaffected
You need to log in
before you can comment on or make changes to this bug.
Description
•