These workarounds for gcc 4.x bugs are no longer needed because Firefox currently requires gcc 6.1 or later (as of bug 1444274). Some of these workarounds were for Firefox for Android which now uses clang instead of gcc (as of bug 1163171). I tested these changes on Try. None of the test failures look related to the removal of these gcc workarounds. https://treeherder.mozilla.org/#/jobs?repo=try&revision=e075db6087e297ee5bc36bbac8c2d3bb8a1d0905

Comment on attachment 8997753 [details] Bug 1481097 - wasm: Remove inline template workaround for gcc 4.8.5 bug. https://reviewboard.mozilla.org/r/261488/#review268494

Comment on attachment 8997751 [details] Bug 1481097 - layout: Remove nsCSSPseudoElements workaround for gcc 4.9.2 bug. https://reviewboard.mozilla.org/r/261484/#review268622

Comment on attachment 8997749 [details] Bug 1481097 - mfbt: Assert we're compiling with gcc 6.1 or later. https://reviewboard.mozilla.org/r/261480/#review268686

Pushed by cpeterson@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/20bf59c86755 mfbt: Assert we're compiling with gcc 6.1 or later. r=glandium https://hg.mozilla.org/integration/mozilla-inbound/rev/8fae317831c1 layout: Remove nsCSSPseudoElements workaround for gcc 4.9.2 bug. r=dbaron https://hg.mozilla.org/integration/mozilla-inbound/rev/d32128ee9a77 wasm: Remove inline template workaround for gcc 4.8.5 bug. r=lth

https://hg.mozilla.org/mozilla-central/rev/20bf59c86755 https://hg.mozilla.org/mozilla-central/rev/8fae317831c1 https://hg.mozilla.org/mozilla-central/rev/d32128ee9a77

Comment on attachment 8997754 [details] Bug 1481097 - xpcom: Remove nsTString literal string workaround for gcc 4.9 bug. https://reviewboard.mozilla.org/r/261490/#review268936

Pushed by cpeterson@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/14f33f70fa0c xpcom: Remove nsTString literal string workaround for gcc 4.9 bug. r=nika

Comment on attachment 8997750 [details] Bug 1481097 - js: Build Array.cpp and JSAtom.cpp in unified mode. Sorry for the lateness.

Pushed by cpeterson@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/eb8f3d884461 js: Build Array.cpp and JSAtom.cpp in unified mode. r=djvj

This gcc 4.8.2 workaround (from bug 1219050) is no longer needed because Firefox currently requires gcc 6.1 or later (as of bug 1444274).

Pushed by cpeterson@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/7e2758590213 vixl: Remove vixl assembler workaround for gcc 4.8.2 bug. r=sstangl

Comment on attachment 8997752 [details] Bug 1481097 - vixl: Remove vixl assembler workaround for gcc 4.8.2 bug. Removing old review request because Sean r+'d this patch in Phabricator: https://phabricator.services.mozilla.com/D5506/new/