Closed
Bug 1481321
Opened 6 years ago
Closed 6 years ago
50KB JS regression after enabling browser.ctrlTab.recentlyUsedOrder
Categories
(Firefox :: Tabbed Browser, defect, P1)
Firefox
Tabbed Browser
Tracking
()
RESOLVED
FIXED
Firefox 63
Tracking | Status | |
---|---|---|
firefox-esr52 | --- | unaffected |
firefox-esr60 | --- | unaffected |
firefox61 | --- | unaffected |
firefox62 | --- | unaffected |
firefox63 | --- | fixed |
People
(Reporter: erahm, Assigned: dao)
References
(Blocks 1 open bug)
Details
(Keywords: regression)
Attachments
(1 file)
(deleted),
patch
|
jaws
:
review+
|
Details | Diff | Splinter Review |
We detected a 50KB regression in the base content JS measure [1] after bug 1473595 landed (this was masked by a 100KB improvement that landed afterwards on m-c). Kris indicated this is probably due to eagerly loading screenshot-related code when loading a tab.
It would be helpful to understand this regression and possibly pursue a backout (or revert the pref to false) if we don't have time to look into it.
Note: to reproduce you'll need to run in a clean profile, the awsy base test can be run locally with:
> ./mach awsy-test testing/awsy/awsy/test_base_memory_usage.py
and on try with
> ./mach try -b o -p linux64 -u awsy-base-e10s --rebuild 5
[1] https://treeherder.mozilla.org/perf.html#/compare?originalProject=mozilla-central&newProject=autoland&newRevision=9fe3f733a48a0c662fd5a3b60195bdeb16c5846d&framework=4&filter=js&selectedTimeRange=172800
Updated•6 years ago
|
Keywords: regression
Assignee | ||
Comment 1•6 years ago
|
||
(In reply to Eric Rahm [:erahm] from comment #0)
> Kris indicated this is probably due to eagerly loading
> screenshot-related code when loading a tab.
That's correct. We automatically generate thumbnails after session restore, and after switching away from a tab. We can probably stop doing both things since generating thumbnails on the fly is fast enough for the limited number of previews we're dealing with here.
Assignee: nobody → dao+bmo
Priority: -- → P1
Assignee | ||
Comment 2•6 years ago
|
||
Attachment #8998128 -
Flags: review?(jaws)
Updated•6 years ago
|
Attachment #8998128 -
Flags: review?(jaws) → review+
Assignee | ||
Updated•6 years ago
|
Keywords: checkin-needed
Pushed by cbrindusan@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/033d948a9332
Stop eagerly creating thumbnails for the Ctrl+Tab panel. r=jaws
Keywords: checkin-needed
Comment 4•6 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 63
Updated•6 years ago
|
status-firefox61:
--- → unaffected
status-firefox62:
--- → unaffected
status-firefox-esr52:
--- → unaffected
status-firefox-esr60:
--- → unaffected
You need to log in
before you can comment on or make changes to this bug.
Description
•