User Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:60.0) Gecko/20100101 Firefox/60.0 Build ID: 20180621121604 Steps to reproduce: I manually updated from TB 52 to TB 60 on Windows 7 with the Classic UI theme. Actual results: The column headers aren't anymore differentiable from the rest of the message list. See the attached screenshot. Expected results: The column headers should have at least grey dividers so that they look different from the rest of the message list, as seen here: https://www.heise.de/imgs/18/2/4/7/8/3/2/6/thunderbird-60-photon-fc1b72940c3ca4a5.png

To clarify: I'm refering to the column headers with "Von|Betreff|" respectively "From|Subject" and so on.

This is a toolkit issue with Windows 7 Classic. On Windows 7 Basic or Aero all is okay. The same happens in Firefox's Bookmarks Library. We use the same code as Firefox for such elements -> redirecting to toolkit.

changeset: 4b8c60ce984e2ad0b69ac72fc969f1de32c389df pushlog_url: https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=6d82e132348fbe33cf3eb7c85c485083c50c6bb9&tochange=4b8c60ce984e2ad0b69ac72fc969f1de32c389df 2018-08-16T13:07:38: DEBUG : Found commit message: Bug 1423453 - Remove -moz-border-*-colors where possible. r=dao MozReview-Commit-ID: JbvngOk18dR

It seems that on Windows's not default themes not the native -moz-appearance:treeheadercell is used but instead the CSS styling, weird. Dão, would you have this styling back for @media (-moz-windows-default-theme: 0) in toolkit? If not, I'll style this in TB.

Since ESR60 is affected here, it would be easier to do this in TB.

We can add back a CSS border, but not with -moz-border-*-colors because that's not supported anymore.

Okay, this is the patch for 63.

And this for ESR60. This should apply to beta too.

Comment on attachment 9001746 [details] [diff] [review] bug1481544.patch >+/* treecol styling for non-default themes */ >+@media (-moz-windows-default-theme: 0) { Use @media (-moz-windows-classic)?

Comment on attachment 9001748 [details] [diff] [review] bug1481544-ESR60-62.patch >--- a/toolkit/themes/windows/global/listbox.css >+++ b/toolkit/themes/windows/global/listbox.css >@@ -65,16 +65,35 @@ > .listheader-icon { > margin-inline-end: 2px; > } > > .listheader-label { > margin: 0px !important; > } > >+/* listheader styling for non-default themes */ >+@media (-moz-windows-default-theme: 0) { ditto

Ah yes, this seems to apply to HC themes on Win7 too.

Patch for ESR60 and 62.

Comment on attachment 9001900 [details] [diff] [review] bug1481544.patch for 63 >+/* treecol styling for non-default themes */ Just remove this comment as it's not really helpful and also slightly wrong.

Comment on attachment 9001901 [details] [diff] [review] bug1481544-ESR60-62.patch for ESR60 and 62 >--- a/toolkit/themes/windows/global/listbox.css >+++ b/toolkit/themes/windows/global/listbox.css >@@ -65,16 +65,35 @@ > .listheader-icon { > margin-inline-end: 2px; > } > > .listheader-label { > margin: 0px !important; > } > >+/* listheader styling for non-default themes */ ditto >--- a/toolkit/themes/windows/global/tree.css >+++ b/toolkit/themes/windows/global/tree.css >@@ -210,16 +210,37 @@ > > .treecol-image:hover:active { > padding-top: 1px; > padding-bottom: 0; > padding-inline-start: 2px; > padding-inline-end: 0; > } > >+/* treecol styling for non-default themes */ ditto

Addressed comment.

Approval Request Comment [Feature/Bug causing the regression]: bug 1423453 [User impact if declined]: user doesn't see the column headers correctly [Is this code covered by automated tests?]: No [Has the fix been verified in Nightly?]: patch is about to land [Needs manual test from QE? If yes, steps to reproduce]: in bookmarks library check the column headers under Windows 7 Classic/HC [Is the change risky?]: no [Why is the change risky/not risky?]: only CSS in a media query [String changes made/needed]: no

Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/337ba2284d5c Style the treecol with CSS on Windows Classic and HC themes. r=dao

Does listheader in richlistbox.css need this fix as well ? https://searchfox.org/mozilla-central/search?q=listheader&case=true&regexp=false&path=richlistbox.css

(In reply to Tim Nguyen :ntim from comment #19) > Does listheader in richlistbox.css need this fix as well ? Inside listheader are treecol used which are styled by tree.css or for the in-content pages the in-content CSS. I see no problem with today Nightly on Win7 Classic.

Comment on attachment 9001910 [details] [diff] [review] bug1481544-ESR60-62.patch for ESR60 and 62 Not a recent regression and it's the very end of the 62 beta cycle, but I don't see any good reason not to uplift this minor css fix limited to win7.

Confirmed the issue over the 62.0b17 version. Based on steps mentioned at Comment 16; fix verified on 62.0b19 and 63.0a1 (2018-08-21) on Windows 7 using the basic/classic theme.

Comment on attachment 9001910 [details] [diff] [review] bug1481544-ESR60-62.patch for ESR60 and 62 Simple CSS fix to improve things on Windows classic themes. Approved for ESR 60.2.

Verified on 60.2 ESR as well.