Closed
Bug 1481776
Opened 6 years ago
Closed 6 years ago
Refactor Marionette code to it's own module
Categories
(Testing :: geckodriver, enhancement, P2)
Tracking
(firefox63 fixed)
RESOLVED
FIXED
mozilla63
Tracking | Status | |
---|---|---|
firefox63 | --- | fixed |
People
(Reporter: whimboo, Assigned: whimboo)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
(deleted),
patch
|
ato
:
review+
|
Details | Diff | Splinter Review |
Once the Serde patch landed via bug 1396821 most of the ToMarionette traits might not be necessary anymore, or would need some changes. I assume that we still want to keep the data structures between the webdriver protocol, and Marionette separate. In that case we would have to create new types and help Serde to serialize those.
Comment 1•6 years ago
|
||
Ideally there should be a Marionette Rust crate that is separated from geckodriver.
Assignee | ||
Comment 2•6 years ago
|
||
With separate data structures as expected by Marionette? Sounds fine to me.
Updated•6 years ago
|
Priority: -- → P3
Assignee | ||
Updated•6 years ago
|
Assignee | ||
Updated•6 years ago
|
Summary: Refactor ToMarionette traits in geckodriver → Refactor Marionette code to it's own module
Assignee | ||
Comment 3•6 years ago
|
||
Assignee | ||
Comment 4•6 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=832f8df84e9a8ea323a1dae4d2b480a0d7cf04d1
Assignee | ||
Updated•6 years ago
|
Attachment #9004233 -
Flags: review?(james)
Assignee | ||
Comment 5•6 years ago
|
||
Comment on attachment 9004233 [details] [diff] [review] [geckodriver] Move WebDriver related code into the command module Missed that James is out today. Andreas, if you have the time feel free to pick it up. Otherwise we will wait. Thanks.
Attachment #9004233 -
Flags: review?(ato)
Updated•6 years ago
|
Attachment #9004233 -
Flags: review?(ato) → review+
Assignee | ||
Comment 6•6 years ago
|
||
Comment on attachment 9004233 [details] [diff] [review] [geckodriver] Move WebDriver related code into the command module Review of attachment 9004233 [details] [diff] [review]: ----------------------------------------------------------------- Thanks Andreas!
Attachment #9004233 -
Flags: review?(james)
Pushed by hskupin@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/fb80a4f44ac2 [geckodriver] Move WebDriver related code into the command module. r=ato
Comment 8•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/fb80a4f44ac2
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox63:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in
before you can comment on or make changes to this bug.
Description
•