Closed
Bug 1481858
Opened 6 years ago
Closed 6 years ago
Documentation for JS shell's 'newGlobal' function is out of date
Categories
(Core :: JavaScript Engine, enhancement)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla63
| Tracking | Status | |
|---|---|---|
| firefox63 | --- | fixed |
People
(Reporter: jimb, Assigned: jimb)
Details
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
jimb
:
review+
|
Details | Diff | Splinter Review |
The documentation for the SpiderMonkey shell's 'newGlobal' built-in function doesn't describe all the options it accepts.
|
Assignee | |
Comment 1•6 years ago
|
||
|
||
Comment 2•6 years ago
|
||
Comment on attachment 8998561 [details] [diff] [review]
Update JS shell's newGlobal function's docs.
Review of attachment 8998561 [details] [diff] [review]:
-----------------------------------------------------------------
Thanks for fixing this!
::: js/src/shell/js.cpp
@@ +7262,5 @@
> " Return the filename of the current script"),
>
> JS_FN_HELP("newGlobal", NewGlobal, 1, 0,
> "newGlobal([options])",
> " Return a new global object in a new compartment. If options\n"
Nit: maybe this should be "new realm" instead of "new compartment" now?
Attachment #8998561 -
Flags: review?(jdemooij) → review+
|
|
Assignee | |
Comment 3•6 years ago
|
||
Updated per review. Carrying over r=jandem.
Attachment #8998561 -
Attachment is obsolete: true
Attachment #8998990 -
Flags: review+
|
|
Assignee | |
Updated•6 years ago
|
Keywords: checkin-needed
Pushed by nerli@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8f74896e5c9b
Update JS shell's newGlobal function's docs. r=jandem
Keywords: checkin-needed
|
||
Comment 5•6 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox63:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in
before you can comment on or make changes to this bug.
Description
•