As a result of the patch in bug 98673, the session-logout signal is no longer being issued. The code for handling that signal should be removed. This occurs in the following place /security/manager/ssl/src/nsNSSComponent.cpp, line 1351 -- #define SESSION_LOGOUT_TOPIC NS_LITERAL_CSTRING("session-logout").get()

->PSM

kai

This has a negative consequence: At the time that event was received, we would log the user out of any security devices in use. That includes the software device and any hardware tokens. If we no longer do that, the tokens will still be logged in. The log out behaviour was initially requested in bug 101263 and I think it is reasonable. Is there another event we could listen to alternatively?

changing obsolete psm* target to --- (unspecified)

<http://mxr.mozilla.org/seamonkey/search?string=session-logout&case=on&find=%5C.cpp%24&filter=%5E%5B%5E%5C0%5D*%24&tree=seamonkey> {{ /security/manager/ssl/src/nsNSSComponent.cpp * line 1954 -- #define SESSION_LOGOUT_TOPIC "session-logout" }} <http://mxr.mozilla.org/seamonkey/search?string=SESSION_LOGOUT_TOPIC&case=on&find=%2Fssl%2Fsrc%2FnsNSSComponent.cpp&filter=%5E%5B%5E%5C0%5D*%24&tree=seamonkey> {{ /security/manager/ssl/src/nsNSSComponent.cpp * line 1954 -- #define SESSION_LOGOUT_TOPIC "session-logout" * line 2041 -- else if ((nsCRT::strcmp(aTopic, SESSION_LOGOUT_TOPIC) == 0) && mNSSInitialized) { * line 2179 -- observerService->AddObserver(this, SESSION_LOGOUT_TOPIC, PR_FALSE); }}

(In reply to comment #3) > Is there another event we could listen to alternatively? <http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/xpfe/bootstrap/nsNativeAppSupportWin.cpp&rev=1.124.2.9&mark=2745,2758#2730> 1.8(.1) branch </xpfe/*> code: bug 98673 fix is creating a new process and quitting the current one. I would guess/hope we are already getting some other event which somehow triggers the security log out code too. Or would that be the other event we are looking for ? <http://mxr.mozilla.org/mozilla/source/toolkit/xre/nsNativeAppSupportWin.cpp> 1.9(.0) trunk(/branch) </toolkit/*> code: "Bug 361682 – Remove "turbo mode" from suiterunner builds" says it all.

Kaie, ping ? (NB: This is the last occurrence of such code.)

Comment on attachment 326000 [details] [diff] [review] (Av1-19T) <nsNSSComponent.cpp> [Checkin: Comment 10] r=kaie

Pushed as 17115:4227664954fd.