Closed
Bug 1482020
Opened 6 years ago
Closed 6 years ago
Make HTMLEditor::InsertTableCell(() use non-virtual HTMLEditor::CreateElementWithDefaults() instead of nsIHTMLEditor::CreateElementWithDefaults()
Categories
(Core :: DOM: Editor, enhancement, P3)
Core
DOM: Editor
Tracking
()
RESOLVED
FIXED
mozilla63
| Tracking | Status | |
|---|---|---|
| firefox63 | --- | fixed |
People
(Reporter: masayuki, Assigned: masayuki)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
No description provided.
|
Assignee | |
Comment 1•6 years ago
|
||
|
|
Assignee | |
Comment 2•6 years ago
|
||
|
|
Assignee | |
Comment 3•6 years ago
|
||
|
|
Assignee | |
Comment 4•6 years ago
|
||
Fortunately, despite of becoming public method,
HTMLEditor::CreateElementWithDefaults() can be used by internal methods too
since it does not touch undo transactions nor the DOM tree, and does not
refer mRules nor GetSelection(). So, we can make it public and make any
C++ callers use it.
|
||
Comment 5•6 years ago
|
||
Comment on attachment 8999611 [details]
Bug 1482020 - Make all callers of CreateElementWithDefaults() use non-virtual method
Makoto Kato [:m_kato] has approved the revision.
Attachment #8999611 -
Flags: review+
|
|
||
Updated•6 years ago
|
Priority: -- → P3
Pushed by masayuki@d-toybox.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/417967cf69de
Make all callers of CreateElementWithDefaults() use non-virtual method r=m_kato
|
||
Comment 7•6 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
|
|
Assignee | |
Updated•5 years ago
|
Blocks: redesign-editor-scriptable-API
You need to log in
before you can comment on or make changes to this bug.
Description
•