Closed
Bug 1482108
Opened 6 years ago
Closed 6 years ago
@searches do not search in their respective engines if the Address bar arrow is clicked
Categories
(Firefox :: Address Bar, defect)
Firefox
Address Bar
Tracking
()
RESOLVED
DUPLICATE
of bug 1482125
Tracking | Status | |
---|---|---|
firefox-esr52 | --- | unaffected |
firefox-esr60 | --- | unaffected |
firefox61 | --- | unaffected |
firefox62 | --- | unaffected |
firefox63 | --- | affected |
People
(Reporter: cmuresan, Unassigned)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
(deleted),
image/gif
|
Details |
[Affected versions]:
- Nightly v63.0a1, Build ID 20180809033813
[Affected Platforms]:
- All Windows
- All Mac
- All Linux
[Steps to reproduce]:
1. Open the browser with a clean new profile and focus the Address bar.
2. Write "@amazon test" and click the Address bar arrow.
3. Observe the behavior.
[Expected results]:
- The string "test" is searched on Amazon.
[Actual results]:
- The string "@amazon test" is searched on the default search engine.
[Notes]:
- The issue is also reproducible with the @google keyword.
- The issue is not reproducible if you write the wring and press the Enter key.
- The issue is NOT reproducible if you focus the next suggestion and then come back to the @amazon/google one. In this case, the search is made in for the keyword in the Amazon/Google search engine. In both cases, the @amazon/google suggestion is the one hovered.
- Attached a screen recording of the issue.
Comment 1•6 years ago
|
||
This is probably because we only added the internal alias for the autocomplete results and not a full on alias, which is what the autocomplete-less / arrow click uses . ?
Blocks: 1479806
Component: Activity Streams: Newtab → Address Bar
Comment 2•6 years ago
|
||
The core difference is how the alias is turned into an action.
When enter is pressed, we get an action URL in handleCommand in urlbarBindings.xml
moz-action:searchengine,{"engineName":"Amazon.com","input":"%40amazon%20test","searchQuery":"test","alias":"%40amazon"} urlbarBindings.xml:780
When the arrow is clicked, we get the actual text through:
@amazon test
So these are two completely different paths when they are effectively doing the same thing.
I would bet there are other differences as well.
Comment 3•6 years ago
|
||
So yes, the other cases are covered by this code:
https://searchfox.org/mozilla-central/source/browser/base/content/browser.js#2422
I do think it is odd that clicking enter doesn't use the action URL considering it is available somewhere.
We should probably fix that at some point.
Comment 4•6 years ago
|
||
I'm fixing this with the rework in bug 1482125.
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → DUPLICATE
You need to log in
before you can comment on or make changes to this bug.
Description
•