Closed
Bug 1482184
Opened 6 years ago
Closed 6 years ago
Scrolling without the Web Search section is janky
Categories
(Firefox :: New Tab Page, defect, P1)
Firefox
New Tab Page
Tracking
()
People
(Reporter: rrosario, Assigned: rrosario)
References
(Blocks 1 open bug)
Details
(Keywords: regression)
Attachments
(1 file)
(deleted),
text/x-github-pull-request
|
Details |
Caused by Bug 1481677.
When switching the search bar to a fixed header we need to add some top padding to make up for the space where the search bar is in the content while scrolling. We cant add that padding if there is no search section.
Comment 1•6 years ago
|
||
Comment 2•6 years ago
|
||
Commits pushed to master at https://github.com/mozilla/activity-stream
https://github.com/mozilla/activity-stream/commit/aab3771a50215d97ed4f34c7056f46a0f943a822
Fix Bug 1482184 - only apply fixed-search if search section is visible
https://github.com/mozilla/activity-stream/commit/e4b2ac4af96481ee6b4bd4bbb2c2ff6d3213ade0
Merge pull request #4304 from rlr/bug1482184/scroll-fix
Fix Bug 1482184 - only apply fixed-search if search section is visible
Updated•6 years ago
|
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Comment 3•6 years ago
|
||
qa note: this regressed from bug 1481677 which never made it to nightly in its own export, so you can't verify that the bug exists with an earlier nightly.
Comment 4•6 years ago
|
||
status-firefox63:
--- → fixed
Target Milestone: --- → Firefox 63
Comment 5•6 years ago
|
||
I'm marking this issue as "Verified Fixed" based on comment 3 and on the resolution from Bug 1481677.
Status: RESOLVED → VERIFIED
Comment 6•6 years ago
|
||
status-firefox62:
--- → fixed
Updated•6 years ago
|
Keywords: regression
Comment 7•6 years ago
|
||
Marking the issue as verified on Beta 62 as well, based on comment 3 and the verification from bug 1481677 comment 6.
Updated•5 years ago
|
Component: Activity Streams: Newtab → New Tab Page
You need to log in
before you can comment on or make changes to this bug.
Description
•