Closed Bug 1482648 Opened 6 years ago Closed 6 years ago

Remove remaining broadcasters from front-end code

Categories

(Firefox :: General, enhancement, P1)

Product:
Firefox
Component:
General
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 63
Tracking Flags:
Tracking Status
firefox63 --- fixed

People

(Reporter: Paolo, Assigned: Paolo)

References

Details

Attachments

(4 files)

Bug 1482648 - Part 1 - Convert the offline broadcaster to a command. r=bgrins
(deleted), text/x-phabricator-request
bgrins
: review+
Details
Bug 1482648 - Part 2 - Remove unneeded indirection in devtools broadcasters. r=bgrins
(deleted), text/x-phabricator-request
bgrins
: review+
Details
Bug 1482648 - Part 3 - Remove remaining broadcasters from front-end code. r=bgrins
(deleted), text/x-phabricator-request
bgrins
: review+
Details
Bug 1482648 - Part 4 - Clean up remaining references to broadcasters in front-end code. r=bgrins
(deleted), text/x-phabricator-request
bgrins
: review+
Details
This is the last part of the broadcaster removal in bug 1479908.
Still working on fixing tests and review comments on the patch series. Complete tryserver build as of now: https://treeherder.mozilla.org/#/jobs?repo=try&revision=c38a57f579eb3c72b875c81f59ecd3ed4b879aac
Comment on attachment 8999383 [details] Bug 1482648 - Part 2 - Remove unneeded indirection in devtools broadcasters. r=bgrins Brian Grinstead [:bgrins] has approved the revision.
Attachment #8999383 - Flags: review+
Comment on attachment 8999384 [details] Bug 1482648 - Part 3 - Remove remaining broadcasters from front-end code. r=bgrins Brian Grinstead [:bgrins] has approved the revision.
Attachment #8999384 - Flags: review+
Comment on attachment 8999385 [details] Bug 1482648 - Part 4 - Clean up remaining references to broadcasters in front-end code. r=bgrins Brian Grinstead [:bgrins] has approved the revision.
Attachment #8999385 - Flags: review+
Comment on attachment 8999382 [details] Bug 1482648 - Part 1 - Convert the offline broadcaster to a command. r=bgrins Brian Grinstead [:bgrins] has approved the revision.
Attachment #8999382 - Flags: review+
I've fixed an issue and renamed related variables for clarity. Tryserver build: https://treeherder.mozilla.org/#/jobs?repo=try&revision=225710040db9fc51039697ebf2d50112cf27bd8f
Pushed by paolo.mozmail@amadzone.org: https://hg.mozilla.org/integration/mozilla-inbound/rev/4c42ea4583b2 Part 1 - Convert the offline broadcaster to a command. r=bgrins https://hg.mozilla.org/integration/mozilla-inbound/rev/29f7da1bf5f7 Part 2 - Remove unneeded indirection in devtools broadcasters. r=bgrins https://hg.mozilla.org/integration/mozilla-inbound/rev/981a904be103 Part 3 - Remove remaining broadcasters from front-end code. r=bgrins https://hg.mozilla.org/integration/mozilla-inbound/rev/bf68c78fb859 Part 4 - Clean up remaining references to broadcasters in front-end code. r=bgrins
Depends on: 1486984
Depends on: 1497926
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: